linux-kernel - Re: [PATCH 1/3] leds: trigger: legtrig-bpf: Add ledtrig-bpf module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ceeefde3-68a6-4fc9-87a0-401206037855@lunn.ch>
Date: Sat, 23 Mar 2024 23:25:42 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc: Daniel Hodges <hodges.daniel.scott@...il.com>,
	netfilter-devel <netfilter-devel@...r.kernel.org>,
	Network Development <netdev@...r.kernel.org>,
	Alexei Starovoitov <ast@...nel.org>, Pavel Machek <pavel@....cz>,
	Lee Jones <lee@...nel.org>, linux-leds@...r.kernel.org,
	Daniel Borkmann <daniel@...earbox.net>, bpf <bpf@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] leds: trigger: legtrig-bpf: Add ledtrig-bpf module

> A new kernel module just to call this helper?
> Feels like overkill. Can it be a part of generic led bits?
> btw, have you looked at net/netfilter/xt_LED.c ?
> netfilter had the ability to blink led for a long time.
> I'm curious whether folks found it useful.

This might become more useful now that we have support for PHY & MAC
LEDs. You can use the netdev trigger for the usual things an RJ45 LED
shows: link, rx/tx activity, link speed etc. But they are just Linux
LEDs, you can also use them for heartbeat, disc IO, tty IO, or xt_LED.
xt_LED would actually make sense for an LED in a RJ45 socket.

       Andrew