linux-kernel - Re: [PATCH 1/4] dt-bindings: rtc: armada-380-rtc: convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e68e0ca-2f3e-41a7-bb96-00fbdadc4436@gmail.com>
Date: Sun, 24 Mar 2024 01:02:31 +0100
From: Javier Carrasco <javier.carrasco.cruz@...il.com>
To: Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc: Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Baruch Siach <baruch@...s.co.il>,
 linux-rtc@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/4] dt-bindings: rtc: armada-380-rtc: convert to dtschema

On 3/24/24 00:37, Alexandre Belloni wrote:
> On 23/03/2024 23:46:13+0100, Javier Carrasco wrote:
>> Convert existing binding to dtschema to support validation.
>>
>> +required:
>> +  - compatible
>> +  - reg
>> +  - reg-names
>> +  - interrupts
>> +
>> +additionalProperties: false
> 
> This is not correct because at least start-year is supported. Please
> check for all your other submissions too.
> 

allOf:
  - $ref: rtc.yaml#

is missing, and then

unvealuatedProperties: false

to account for that.

"start-year" is read in the RTC base class, so I wonder why so many RTC
bindings add a reference to rtc.yaml, but then use

additionalProperties: false

>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +
>> +    rtc@...00 {
>> +        compatible = "marvell,armada-380-rtc";
>> +        reg = <0xa3800 0x20>, <0x184a0 0x0c>;
>> +        reg-names = "rtc", "rtc-soc";
>> +        interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
>> +    };
>>
>> -- 
>> 2.40.1
>>
> 

Thanks and best regards,
Javier Carrasco