linux-kernel - Re: [PATCH -next RFC] blk-throttle: remove CONFIG_BLK_DEV_THROTTLING

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bf3715e1-bf44-44e6-8877-4bbcfe5f3f98@infradead.org>
Date: Fri, 22 Mar 2024 20:17:26 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Yu Kuai <yukuai1@...weicloud.com>, axboe@...nel.dk, tj@...nel.org,
 hch@....de, ming.lei@...hat.com, josef@...icpanda.com
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
 cgroups@...r.kernel.org, yukuai3@...wei.com, yi.zhang@...wei.com,
 yangerkun@...wei.com
Subject: Re: [PATCH -next RFC] blk-throttle: remove
 CONFIG_BLK_DEV_THROTTLING_LOW

Hi--

On 3/22/24 19:53, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@...wei.com>
> 
> One the one hand, it's marked EXPERIMENTAL since 2017, and looks like
> there are no users since then, and no testers and no developers, it's
> just not active at all.
> 
> On the other hand, even if the config is disabled, there are still many
> fields in throtl_grp and throtl_data and many functions that are only
> used for throtl low.
> 
> At last, currently blk-throtl is initialized during disk initialization,
> and destroyed during disk removal, and it exposes many functions to be
> called directly from block layer. Hence I'm planning to optimize
> blk-throtl and finially support building it as kernel module. Remove
> throtl low will make the work much easier.
> 
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>
> ---
>  block/Kconfig        |  11 -
>  block/bio.c          |   1 -
>  block/blk-stat.c     |   3 -
>  block/blk-sysfs.c    |   7 -
>  block/blk-throttle.c | 901 ++-----------------------------------------
>  block/blk-throttle.h |  26 +-
>  block/blk.h          |  11 -
>  7 files changed, 45 insertions(+), 915 deletions(-)

Here are 2 more places to patch:

Documentation/ABI/stable/sysfs-block:           CONFIG_BLK_DEV_THROTTLING_LOW is enabled.
arch/loongarch/configs/loongson3_defconfig:CONFIG_BLK_DEV_THROTTLING_LOW=y


-- 
#Randy