linux-kernel - Re: [PATCH v3 0/3] Trivial code cleanup patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zf5NCuZ/JNbcSpky@aschofie-mobl2>
Date: Fri, 22 Mar 2024 20:31:22 -0700
From: Alison Schofield <alison.schofield@...el.com>
To: Ayush Tiwari <ayushtiw0110@...il.com>
Cc: Larry.Finger@...inger.net, florian.c.schilhabel@...glemail.com,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	linux-staging@...ts.linux.dev, outreachy@...ts.linux.dev
Subject: Re: [PATCH v3 0/3] Trivial code cleanup patches

On Thu, Mar 21, 2024 at 02:55:07AM +0530, Ayush Tiwari wrote:
> Address different kinds of checkpatch complains for the rtl8712 module
> to ensure adherence to coding style guidelines.

Thanks for sending v3 as a new email, rather than threaded with
prior revisions.

I think you repeat the changelog in the patches, but I'll go
ahead and comment right here. It applies in the patch too.

> 
> Changes in v3: Fixed issues about backupPMKIDList and verified with
> CONFIG_WERROR set and built the kernel.
> 
> Changes in v2: Checked any possible reuse of backup_PMKID_list
> manually and rebuilt, rebooted the kernel and loaded the driver
> with modprobe.

The change log is to inform reviewers of what actually changed
in the patch since previous version. So let's be specific
in these v2, v3, and next a v4 changelog. I think this is
right:

v4: Update the changelog to match revision history
v3: Update memcpy() param to match new name backup_PMKID_list
v2: No changes. Just a patch sending error.

There's a section in the first patch tutorial about replying to
patch feedback and you can read any of the lore lists to see
examples. Folks will expect you to reply to their feedback.
Even if it's just a simple "Thanks, got it!" Then, they will
look to see if their feedback affected the next revision.

--Alison

> 
> Ayush Tiwari (3):
>   staging: rtl8712: rename backupPMKIDList to backup_PMKID_list
>   staging: rtl8712: rename backupPMKIDIndex to backup_PMKID_index
>   staging: rtl8712: rename backupTKIPCountermeasure to
>     backup_TKIP_countermeasure
> 
>  drivers/staging/rtl8712/mlme_linux.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> -- 
> 2.40.1
> 
>