linux-kernel - Re: [PATCH] crash: use macro to add crashk_res into iomem early for specific arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zf/51a+QonYj6sI7@MiWiFi-R3L-srv>
Date: Sun, 24 Mar 2024 18:00:53 +0800
From: Baoquan He <bhe@...hat.com>
To: Ingo Molnar <mingo@...nel.org>
Cc: kexec@...ts.infradead.org, linux-kernel@...r.kernel.org, x86@...nel.org,
	akpm@...ux-foundation.org, chenhuacai@...ngson.cn,
	dyoung@...hat.com, jbohac@...e.cz, lihuafei1@...wei.com,
	chenhaixiang3@...wei.com
Subject: Re: [PATCH] crash: use macro to add crashk_res into iomem early for
 specific arch

On 03/24/24 at 05:06am, Ingo Molnar wrote:
> 
> * Baoquan He <bhe@...hat.com> wrote:
> 
.....snip
> > ---
> >  arch/x86/include/asm/crash_reserve.h | 2 ++
> >  kernel/crash_reserve.c               | 7 +++++++
> >  2 files changed, 9 insertions(+)
> > 
> > diff --git a/arch/x86/include/asm/crash_reserve.h b/arch/x86/include/asm/crash_reserve.h
> > index 152239f95541..4681a543eba3 100644
> > --- a/arch/x86/include/asm/crash_reserve.h
> > +++ b/arch/x86/include/asm/crash_reserve.h
> > @@ -39,4 +39,6 @@ static inline unsigned long crash_low_size_default(void)
> >  #endif
> >  }
> >  
> > +# define HAVE_ARCH_ADD_CRASH_RES_TO_IOMEM_EARLY
> > +
> 
> Any reason for that stray space?

No clear reason. I saw stray space was added for macro definning when my
below patch was merged, not sure if this is preferred. And there are
a lot of "# define " when searching with 'git grep "# define " arch/x86/include/'.

commit 85fcde402db1 ("kexec: split crashkernel reservation code out from crash_core.c")