linux-kernel - Re: [PATCH 1/1] arm64: dts: rockchip: disable analog audio for rock-5b

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <XJ_dGL-0X07dJ8GOKvrXbRD2FAHN1A7keAtohcSaU41DEF0FbeWwswLEqkrYiwwulyXDwJ6SZHfWukhHO3t3tOWX7ZGM7ya9lwXfn8Xh1nU=@thefossguy.com>
Date: Sun, 24 Mar 2024 11:43:16 +0000
From: Pratham Patel <prathampatel@...fossguy.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: robh@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, heiko@...ech.de, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] arm64: dts: rockchip: disable analog audio for rock-5b

On Sunday, March 24th, 2024 at 16:51, Pratham Patel <prathampatel@...fossguy.com> wrote:

> On Sunday, March 24th, 2024 at 16:15, Krzysztof Kozlowski krzysztof.kozlowski@...aro.org wrote:
> 
> > > + /*
> > > + *analog-sound {
> > > + * compatible = "audio-graph-card";
> > > + * label = "rk3588-es8316";
> > 
> > Do not comment out code. Instead disable the nodes and provide
> > appropriate comment describing reason.
> 
> I tried changing the status from okay to disabled. That didn't work. The SBC
> still locked up during boot.

I think setting the status to fail should do the trick, instead of setting it to disabled.
Will try that and be back with a v2.

 -- Pratham Patel