[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID:
<DU0PR04MB941796214807CFF880E1A31F88372@DU0PR04MB9417.eurprd04.prod.outlook.com>
Date: Sun, 24 Mar 2024 12:15:19 +0000
From: Peng Fan <peng.fan@....com>
To: Dan Carpenter <dan.carpenter@...aro.org>, "Peng Fan (OSS)"
<peng.fan@....nxp.com>
CC: Sudeep Holla <sudeep.holla@....com>, Cristian Marussi
<cristian.marussi@....com>, Rob Herring <robh+dt@...nel.org>, Krzysztof
Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley
<conor+dt@...nel.org>, Oleksii Moisieiev <oleksii_moisieiev@...m.com>, Linus
Walleij <linus.walleij@...aro.org>, Shawn Guo <shawnguo@...nel.org>, Sascha
Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team
<kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, dl-linux-imx
<linux-imx@....com>, "linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org"
<devicetree@...r.kernel.org>, "linux-gpio@...r.kernel.org"
<linux-gpio@...r.kernel.org>, AKASHI Takahiro <takahiro.akashi@...aro.org>
Subject: RE: [PATCH v5 3/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol
protocol basic support
Hi Dan,
> Subject: Re: [PATCH v5 3/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol
> protocol basic support
>
> On Thu, Mar 21, 2024 at 05:46:53PM +0300, Dan Carpenter wrote:
> > On Thu, Mar 14, 2024 at 09:35:20PM +0800, Peng Fan (OSS) wrote:
> > > +enum scmi_pinctrl_protocol_cmd {
> > > + PINCTRL_ATTRIBUTES = 0x3,
> > > + PINCTRL_LIST_ASSOCIATIONS = 0x4,
> > > + PINCTRL_CONFIG_GET = 0x5,
> > > + PINCTRL_CONFIG_SET = 0x6,
> > > + PINCTRL_FUNCTION_SELECT = 0x7,
> >
> > PINCTRL_FUNCTION_SELECT was removed from the spec so the other cmds
> > were renumbered. I'm still going through and reviewing this file.
> > I'll hopefully be done tomorrow.
> >
>
> I think the rest is okay. It's just updating to the new version of the spec.
> CONFIG_GET/SET need to be updated and FUNCTION_SELECT gets deleted.
V6 has this updated. Thanks for helping reviewing this patchset.
Thanks,
Peng.
>
> regards,
> dan carpenter
Powered by blists - more mailing lists