[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240324124546.2e07f802@jic23-huawei>
Date: Sun, 24 Mar 2024 12:45:46 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Marcelo Schmitt <marcelo.schmitt@...log.com>, lars@...afoo.de,
Michael.Hennerich@...log.com, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
marcelo.schmitt1@...il.com, linux-iio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] iio: adc: Add support for AD4000
On Sat, 23 Mar 2024 16:53:17 -0500
> > +
> > + /*
> > + * DMA (thus cache coherency maintenance) requires the
> > + * transfer buffers to live in their own cache lines.
> > + */
> > + union {
> > + struct {
> > + u8 sample_buf[4];
> > + s64 timestamp;
>
> Usually we see __aligned(8) applied to the timestamp (I'm guessing
> some archs need it?)
>
Good spot. Yes, x86_32 is the one that we most commonly refer to for this.
It aligns s64 to only 32 bits whereas IIO ABI is always naturally aligned.
> > + } scan;
> > + u8 d8[2];
> > + } data __aligned(IIO_DMA_MINALIGN);
> > +};
Powered by blists - more mailing lists