linux-kernel - Re: [PATCH v3 0/6] iio: accel: adxl345: Add spi-3wire feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240324133941.26814432@jic23-huawei>
Date: Sun, 24 Mar 2024 13:39:41 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Lothar Rubusch <l.rubusch@...il.com>
Cc: lars@...afoo.de, Michael.Hennerich@...log.com, robh+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, eraretuya@...il.com
Subject: Re: [PATCH v3 0/6] iio: accel: adxl345: Add spi-3wire feature

On Sat, 23 Mar 2024 12:20:24 +0000
Lothar Rubusch <l.rubusch@...il.com> wrote:

> Pass a function setup() as pointer from SPI/I2C specific modules
> to the core module. Implement setup() to pass the spi-3wire bus
> option, if declared in the device-tree.
> 
> In the core module, then update data_format register
> configuration bits instead of overwriting it. The changes allow
> to remove a data_range field, remove I2C and SPI redundant info
> instances and replace them by a common info array instance.
> 
> Signed-off-by: Lothar Rubusch <l.rubusch@...il.com>
That patch break up seems reasonable (one minor request for a split
in the relevant patch), but normal convention would be do do
refactoring first, then functionality at the end. Also removal stuff
and group, before adding things. 

So roughly speaking reorder as

>   iio: accel: adxl345: Make data_format obsolete
>   iio: accel: adxl345: Remove single info instances
>   iio: accel: adxl345: Group bus configuration
>   dt-bindings: iio: accel: adxl345: Add spi-3wire
>   iio: accel: adxl345: Pass function pointer to core
>   iio: accel: adxl345: Add the spi-3wire

Thanks,

Jonathan



> ---
> V1 -> V2: split into spi-3wire and refactoring
> V2 -> V3: split further, focus on needed changesets
> 
> Lothar Rubusch (6):
>   iio: accel: adxl345: Pass function pointer to core
>   iio: accel: adxl345: Make data_format obsolete
>   iio: accel: adxl345: Add the spi-3wire
>   iio: accel: adxl345: Remove single info instances
>   iio: accel: adxl345: Group bus configuration
>   dt-bindings: iio: accel: adxl345: Add spi-3wire
> 
>  .../bindings/iio/accel/adi,adxl345.yaml       |  2 +
>  drivers/iio/accel/adxl345.h                   | 13 ++++-
>  drivers/iio/accel/adxl345_core.c              | 48 +++++++++++++++----
>  drivers/iio/accel/adxl345_i2c.c               | 22 +++------
>  drivers/iio/accel/adxl345_spi.c               | 32 ++++++-------
>  5 files changed, 75 insertions(+), 42 deletions(-)
>