linux-kernel - Re: [PATCH v5 08/11] devm-helpers: Add resource managed version of debugfs directory create function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240324160828.7f873a96@thinkpad>
Date: Sun, 24 Mar 2024 16:08:28 +0100
From: Marek Behún <kabel@...nel.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Jonathan.Cameron@...wei.com, Laurent.pinchart@...asonboard.com,
 airlied@...il.com, andrzej.hajda@...el.com, arm@...nel.org, arnd@...db.de,
 bamv2005@...il.com, brgl@...ev.pl, daniel@...ll.ch, davem@...emloft.net,
 dianders@...omium.org, dri-devel@...ts.freedesktop.org,
 eajames@...ux.ibm.com, gaurav.jain@....com, gregory.clement@...tlin.com,
 hdegoede@...hat.com, herbert@...dor.apana.org.au, horia.geanta@....com,
 james.clark@....com, james@...iv.tech, jdelvare@...e.com,
 jernej.skrabec@...il.com, jonas@...boo.se, linus.walleij@...aro.org,
 linux-crypto@...r.kernel.org, linux-gpio@...r.kernel.org,
 linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux@...ck-us.net, maarten.lankhorst@...ux.intel.com,
 mazziesaccount@...il.com, mripard@...nel.org, naresh.solanki@...ements.com,
 neil.armstrong@...aro.org, pankaj.gupta@....com,
 patrick.rudolph@...ements.com, rfoss@...nel.org, soc@...nel.org,
 tzimmermann@...e.de
Subject: Re: [PATCH v5 08/11] devm-helpers: Add resource managed version of
 debugfs directory create function

On Sun, 24 Mar 2024 10:21:28 +0100
Christophe JAILLET <christophe.jaillet@...adoo.fr> wrote:

> Le 23/03/2024 à 22:25, Marek Behún a écrit :
> > On Sat, 23 Mar 2024 22:10:40 +0100
> > Christophe JAILLET <christophe.jaillet@...adoo.fr> wrote:
> >   
> 
> ...
> 
> >>>    static int pvt_ts_dbgfs_create(struct pvt_device *pvt, struct device *dev)
> >>>    {
> >>> -	pvt->dbgfs_dir = debugfs_create_dir(dev_name(dev), NULL);
> >>> +	pvt->dbgfs_dir = devm_debugfs_create_dir(dev, dev_name(dev), NULL);
> >>> +	if (IS_ERR(pvt->dbgfs_dir))
> >>> +		return PTR_ERR(pvt->dbgfs_dir);  
> >>
> >> Not sure if the test and error handling should be added here.
> >> *If I'm correct*, functions related to debugfs already handle this case
> >> and just do nothing. And failure in debugfs related code is not
> >> considered as something that need to be reported and abort a probe function.
> >>
> >> Maybe the same other (already existing) tests in this patch should be
> >> removed as well, in a separated patch.  
> > 
> > Functions related to debugfs maybe do, but devm_ resource management
> > functions may fail to allocate release structure, and those errors need
> > to be handled, AFAIK.  
> 
> I would say no.
> If this memory allocation fails, then debugfs_create_dir() will not be 
> called, but that's not a really big deal if the driver itself can still 
> run normally without it.

debugfs_create_dir() will always be called. Resource allocation is done
afterwards, and if it fails, then the created dir will be removed.

But now I don't know what to do, because yes, it seems that the debugfs
errors are being ignored at many places...

> 
> Up to you to leave it as-is or remove what I think is a useless error 
> handling.
> At least, maybe it could be said in the commit log, so that maintainers 
> can comment on it, if they don't spot the error handling you introduce.
> 
> CJ
> 
> > 
> > Marek
> >   
>