linux-kernel - Re: [PATCH] tracing: Fix documentation on tp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a81b4cc-90fd-415d-83c1-fe0f0ca7cac9@infradead.org>
Date: Sat, 23 Mar 2024 17:29:42 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Vitaly Chikunov <vt@...linux.org>, Thomas Gleixner <tglx@...utronix.de>,
 "Steven Rostedt (Red Hat)" <rostedt@...dmis.org>, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH] tracing: Fix documentation on tp_printk cmdline option



On 3/23/24 16:17, Vitaly Chikunov wrote:
> kernel-parameters.txt incorrectly states that workings of
> kernel.tracepoint_printk sysctl depends on "tracepoint_printk kernel
> cmdline option", this is a bit misleading for new users since the actual
> cmdline option name is tp_printk.
> 
> Fixes: 0daa2302968c ("tracing: Add tp_printk cmdline to have tracepoints go to printk()")
> Signed-off-by: Vitaly Chikunov <vt@...linux.org>

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  Documentation/admin-guide/kernel-parameters.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index bb884c14b2f6..623fce7d5fcd 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -6599,7 +6599,7 @@
>  			To turn off having tracepoints sent to printk,
>  			 echo 0 > /proc/sys/kernel/tracepoint_printk
>  			Note, echoing 1 into this file without the
> -			tracepoint_printk kernel cmdline option has no effect.
> +			tp_printk kernel cmdline option has no effect.
>  
>  			The tp_printk_stop_on_boot (see below) can also be used
>  			to stop the printing of events to console at

-- 
#Randy