linux-kernel - Re: [PATCH] riscv: Improve sbi_ecall() code generation by reordering arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 24 Mar 2024 19:19:56 +0100
From: Alexandre Ghiti <alexghiti@...osinc.com>
To: Qingfang Deng <dqfext@...il.com>
Cc: aou@...s.berkeley.edu, linux-kernel@...r.kernel.org, 
	linux-riscv@...ts.infradead.org, palmer@...belt.com, paul.walmsley@...ive.com, 
	samuel.holland@...ive.com
Subject: Re: [PATCH] riscv: Improve sbi_ecall() code generation by reordering arguments

Hi Qingfang,

On Sat, Mar 23, 2024 at 7:26 AM Qingfang Deng <dqfext@...il.com> wrote:
>
> Hi Alexandre,
>
> You can simply make sbi_ecall `__always_inline`, so the C function call
> overhead can be fully avoided.

I understand your point, though I don't think we need to mark
sbi_ecall() as inline, it's not in any hot path so it's not worth it.
This patch simply gets rid of a really useless overhead, but it does
not visibly accelerate anything.

I hope it makes sense,

Thanks,

Alex