linux-kernel - Re: [PATCH v5 RESEND 1/6] platform: x86-android-tablets: other: Add swnode for Xiaomi pad2 indicator LED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Ve5201KNdjvDZYq_unHTKp9wZXPWZXDgStP8y+XjtnWWg@mail.gmail.com>
Date: Sun, 24 Mar 2024 21:29:43 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Kate Hsuan <hpa@...hat.com>
Cc: Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>, linux-leds@...r.kernel.org, 
	platform-driver-x86@...r.kernel.org, Hans de Goede <hdegoede@...hat.com>, 
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, 
	André Apitzsch <git@...tzsch.eu>, 
	linux-kernel@...r.kernel.org, Sebastian Reichel <sre@...nel.org>, linux-pm@...r.kernel.org
Subject: Re: [PATCH v5 RESEND 1/6] platform: x86-android-tablets: other: Add
 swnode for Xiaomi pad2 indicator LED

On Sun, Mar 24, 2024 at 5:02 PM Kate Hsuan <hpa@...hat.com> wrote:
>
> There is a KTD2026 LED controller to manage the indicator LED for Xiaomi
> pad2. The ACPI for it is not properly made so the kernel can't get
> a correct description of it.
>
> This work add a description for this RGB LED controller and also set a

adds
sets

> trigger to indicate the chaging event (bq27520-0-charging). When it is

charging

> charging, the indicator LED will be turn on.

turned

..

> +/* main fwnode for ktd2026 */
> +static const struct software_node ktd2026_node = {
> +       .name = "ktd2026"

Leave a comma, this is not a terminator.

> +};

When I asked about the name I relied on the fact that you have an idea
how it works. So, assuming my understanding is correct, this platform
may not have more than a single LED of this type. Dunno if we need a
comment about this.

..

> +static int __init xiaomi_mipad2_init(void)
> +{
> +       return software_node_register_node_group(ktd2026_node_group);
> +}
> +
> +static void xiaomi_mipad2_exit(void)

__exit ?

> +{
> +       software_node_unregister_node_group(ktd2026_node_group);
> +}

-- 
With Best Regards,
Andy Shevchenko