[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <662306a0-1544-4f16-81cc-68324a0c3172@moroto.mountain>
Date: Mon, 25 Mar 2024 08:52:34 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Shahar Avidar <ikobh7@...il.com>
Cc: gregkh@...uxfoundation.org, elder@...aro.org,
andriy.shevchenko@...ux.intel.com, robh@...nel.org,
parthiban.veerasooran@...rochip.com, linux-staging@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] staging: pi433: Reduce N_PI433_MINORS to conform
with N_SPI_MINORS.
On Sun, Mar 24, 2024 at 11:32:00AM +0200, Shahar Avidar wrote:
> The driver can't actually support 2^20 devices.
> Current RasPis GPIO pins can actually support only 1 device.
> Other or future platforms might support more.
>
Why are you doing this? Is it just a clean up or does it have some
effect on runtime? And if it does have an effect on runtime, what does
that look like to the user? This all needs to be in the commit message.
regards,
dan carpenter
Powered by blists - more mailing lists