linux-kernel - RE: [PATCH v1 1/1] phy: freescale: imx8m-pcie: fix pcie link-up instability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 25 Mar 2024 03:33:32 +0000
From: Hongxing Zhu <hongxing.zhu@....com>
To: Marcel Ziswiler <marcel@...wiler.com>, "linux-phy@...ts.infradead.org"
	<linux-phy@...ts.infradead.org>
CC: dl-linux-imx <linux-imx@....com>, Lucas Stach <l.stach@...gutronix.de>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "kernel@...gutronix.de"
	<kernel@...gutronix.de>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Marcel Ziswiler
	<marcel.ziswiler@...adex.com>, Fabio Estevam <festevam@...il.com>, Heiko
 Stuebner <heiko@...ech.de>, Kishon Vijay Abraham I <kishon@...nel.org>, Marc
 Kleine-Budde <mkl@...gutronix.de>, Rob Herring <robh@...nel.org>, Sascha
 Hauer <s.hauer@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>,
	"tharvey@...eworks.com" <tharvey@...eworks.com>, Vinod Koul
	<vkoul@...nel.org>, Yang Li <yang.lee@...ux.alibaba.com>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>
Subject: RE: [PATCH v1 1/1] phy: freescale: imx8m-pcie: fix pcie link-up
 instability

> -----Original Message-----
> From: Marcel Ziswiler <marcel@...wiler.com>
> Sent: 2024年3月22日 21:07
> To: linux-phy@...ts.infradead.org
> Cc: dl-linux-imx <linux-imx@....com>; Lucas Stach <l.stach@...gutronix.de>;
> linux-arm-kernel@...ts.infradead.org; kernel@...gutronix.de; Hongxing Zhu
> <hongxing.zhu@....com>; linux-kernel@...r.kernel.org; Marcel Ziswiler
> <marcel.ziswiler@...adex.com>; Fabio Estevam <festevam@...il.com>; Heiko
> Stuebner <heiko@...ech.de>; Kishon Vijay Abraham I <kishon@...nel.org>;
> Marc Kleine-Budde <mkl@...gutronix.de>; Rob Herring <robh@...nel.org>;
> Sascha Hauer <s.hauer@...gutronix.de>; Shawn Guo <shawnguo@...nel.org>;
> tharvey@...eworks.com; Vinod Koul <vkoul@...nel.org>; Yang Li
> <yang.lee@...ux.alibaba.com>; imx@...ts.linux.dev
> Subject: [PATCH v1 1/1] phy: freescale: imx8m-pcie: fix pcie link-up instability
> 
> From: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> 
> Leaving AUX_PLL_REFCLK_SEL at its reset default of AUX_IN (PLL clock) proves to
> be more stable on the i.MX 8M Mini.
> 
> Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie standalone
> phy driver")
> 
Hi Marcel
I took look back at the validation codes.
i.MX8MM PCIe doesn't configure cmn_reg063 (offset: 0x18C) indeed.

It's my bad to treat i.MX8MM same as i.MX8MP refer to my assumption on the
 literal meaning of these bit definitions.

Reviewed-by: Richard Zhu <hongxing.zhu@....com>

Best Regards
Richard Zhu

> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> ---
> 
>  drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> index b700f52b7b67..11fcb1867118 100644
> --- a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> +++ b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> @@ -110,8 +110,10 @@ static int imx8_pcie_phy_power_on(struct phy *phy)
>  		/* Source clock from SoC internal PLL */
>  		writel(ANA_PLL_CLK_OUT_TO_EXT_IO_SEL,
>  		       imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG062);
> -		writel(AUX_PLL_REFCLK_SEL_SYS_PLL,
> -		       imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG063);
> +		if (imx8_phy->drvdata->variant != IMX8MM) {
> +			writel(AUX_PLL_REFCLK_SEL_SYS_PLL,
> +			       imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG063);
> +		}
>  		val = ANA_AUX_RX_TX_SEL_TX | ANA_AUX_TX_TERM;
>  		writel(val | ANA_AUX_RX_TERM_GND_EN,
>  		       imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG064);
> --
> 2.44.0