linux-kernel - Re: [PATCH 1/3] dt-bindings: hwmon: Add maxim max31790 driver bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3f296d2-63b0-493e-a2cd-5010dea84adb@linaro.org>
Date: Mon, 25 Mar 2024 09:32:04 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Chanh Nguyen <chanh@...eremail.onmicrosoft.com>,
 Chanh Nguyen <chanh@...amperecomputing.com>, Jean Delvare
 <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Justin Ledford
 <justinledford@...gle.com>, devicetree@...r.kernel.org,
 linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
 OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
 Open Source Submission <patches@...erecomputing.com>
Cc: Phong Vo <phong@...amperecomputing.com>,
 Thang Nguyen <thang@...amperecomputing.com>,
 Quan Nguyen <quan@...amperecomputing.com>
Subject: Re: [PATCH 1/3] dt-bindings: hwmon: Add maxim max31790 driver
 bindings

On 22/03/2024 10:53, Chanh Nguyen wrote:
>>>>
>>>
>>> Hi Krzysztof,
>>> I have not yet understood your comment here. Please help give more
>>> details for my missing! Thank Krzysztof!
>>
>> I expect many more properties of a fan controller. Resources (clocks,
>> PWMs, supplies) and FAN specific properties.
>>
> 
> Hi Krzysztof,
> 
> I'm creating a base binding document for the max31790 driver. I'm basing 
> it on the drivers/hwmon/max31790.c. Currently, the max31790.c driver has 

Binding should be based on device (e.g. its datasheet), not the driver.

> not yet implemented other properties, such as clocks, fan-supply, pwms, 
> etc. So I just introduced the "compatible" and "reg" properties.
> 
> In the near future, if any other properties are necessary, I think we 
> will implement them in drivers/hwmon/max31790.c then update this binding 
> document.

Please instead read:
Documentation/devicetree/bindings/writing-bindings.rst

> 
> I look at other binding documents, I also see something similar. They 
> just introduce the "compatible" and "reg" properties.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/hwmon/adi,max31760.yaml 

Maybe these devices are similar, maybe not. This should not be excuse to
come with really incomplete binding.

..

> I think "fan-controller" is a good node name. Do you think so?
> 

Yes.

Best regards,
Krzysztof