linux-kernel - Re: [PATCH] mtd: rawnand: qcom: Fix broken misc_cmd_type in exec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 25 Mar 2024 10:19:30 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc: Christian Marangi <ansuelsmth@...il.com>, Richard Weinberger
 <richard@....at>, Vignesh Raghavendra <vigneshr@...com>, Sricharan
 Ramabadhran <quic_srichara@...cinc.com>, Md Sadre Alam
 <quic_mdalam@...cinc.com>, linux-mtd@...ts.infradead.org,
 linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH] mtd: rawnand: qcom: Fix broken misc_cmd_type in exec_op

Hi,

manivannan.sadhasivam@...aro.org wrote on Fri, 22 Mar 2024 20:35:10
+0530:

> On Wed, Mar 20, 2024 at 01:11:39AM +0100, Christian Marangi wrote:
> > misc_cmd_type in exec_op have multiple problems. With commit a82990c8a409
> > ("mtd: rawnand: qcom: Add read/read_start ops in exec_op path") it was
> > reworked and generalized but actually dropped the handling of the
> > RESET_DEVICE command.
> > 
> > The rework itself was correct with supporting case where a single misc
> > command is handled, but became problematic by the addition of exiting
> > early if we didn't had an ERASE or an OP_PROGRAM_PAGE operation.
> > 
> > Also additional logic was added without clear explaination causing the
> > erase command to be broken on testing it on a ipq806x nandc.
> >   
> 
> Interesting. I believe Alam tested the rework on IPQ platforms and not sure how
> it got missed.
> 
> > Add some additional logic to restore RESET_DEVICE command handling and
> > fix erase command.
> >   
> 
> This sounds like two independent fixes, no? Please split them into separate
> patches.

Might be split indeed. @Christian, do you plan on sending a v2?

Thanks,
Miquèl