linux-kernel - Re: [PATCH] arm64: dts: exynos: gs101: define all PERIC USI nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3b38abb9-c3ac-4b55-889a-424396f1113d@linaro.org>
Date: Mon, 25 Mar 2024 09:22:59 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Tudor Ambarus <tudor.ambarus@...aro.org>, peter.griffin@...aro.org,
 robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org
Cc: alim.akhtar@...sung.com, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, andre.draszik@...aro.org,
 willmcvicker@...gle.com, kernel-team@...roid.com
Subject: Re: [PATCH] arm64: dts: exynos: gs101: define all PERIC USI nodes

On 22/03/2024 14:39, Tudor Ambarus wrote:
>>
>>> +				#address-cells = <1>;
>>> +				#size-cells = <0>;
> 
> I'd like to respin this patch. Any preference on coding style for
> #address-cells and #size-cells? I guess they shall be above ranges
> property if present.

No, ranges should be just after reg, because it encodes often the same
or similar information (see also DTS Coding Style). I don't have
guideline, can be anywhere before vendor properties.

> 
>>> +				pinctrl-names = "default";
>>> +				pinctrl-0 = <&hsi2c1_bus>;
>>
>> Please reverse two lines, first pinctrl-0 then pinctrl-names. I know we
> 
> Ok.
> 
>> did not follow this convention till now, but at least new code can be
>> correct. Also clocks should be before pinctrl, so we keep some sort of
>> alphabetical order.
> 
> Ok.
> 
> I guess the order shall be:
> 
> 1. compatible
> 2. reg

3. ranges

> 3. #address-cells (if applicable)
>    #size-cells (if applicable)

> 5. Standard/common properties ordered alphabetically (ex. clocks,
>    interrupts, pinctrl)
> 6. vendor-specific properties
> 7. status (if applicable)
> 

Rest looks fine, thanks.

Best regards,
Krzysztof