linux-kernel - Re: [PATCH v4] hwmon:Add EC Chip driver for Lenovo ThinkStation motherboards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 25 Mar 2024 14:13:39 +0200
From: Andy Shevchenko <andy@...ck.fi.intel.com>
To: Guenter Roeck <linux@...ck-us.net>
Cc: David Ober <dober6023@...il.com>, linux-hwmon@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	jdelvare@...e.com, corbet@....net, dober@...ovo.com,
	mpearson@...ovo.com
Subject: Re: [PATCH v4] hwmon:Add EC Chip driver for Lenovo ThinkStation
 motherboards

On Wed, Mar 20, 2024 at 10:59:34AM -0700, Guenter Roeck wrote:
> On Fri, Mar 15, 2024 at 07:58:10AM -0400, David Ober wrote:
> > This addition adds in the ability for the system to scan
> > the EC chip in the Lenovo ThinkStation systems to get the
> > current fan RPM speeds the Maximum speed value for each
> > fan also provides the CPU, DIMM other thermal statuses
> > 
> > Signed-off-by: David Ober <dober@...ovo.com>
> > Signed-off-by: David Ober <dober6023@...il.com>
> 
> Applied to hwmon-next.
> 
> Please note that I'll push the branch after the commit window closed.

Hmm... Was it even compiled?

lenovo-ec-sensors.c:154:31: error: expected '}'
static int p8_fan_map[] = {0. 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 14};
                              ^
lenovo-ec-sensors.c:154:27: note: to match this '{'
static int p8_fan_map[] = {0. 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 14};
                          ^

-- 
With Best Regards,
Andy Shevchenko