linux-kernel - Re: [PATCH 04/28] sound: intel: Use PCI_IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3edd5823-bf54-4898-bcee-e1628c863388@linux.intel.com>
Date: Mon, 25 Mar 2024 13:34:51 +0100
From: Amadeusz Sławiński
 <amadeuszx.slawinski@...ux.intel.com>
To: Damien Le Moal <dlemoal@...nel.org>, linux-pci@...r.kernel.org,
 Bjorn Helgaas <bhelgaas@...gle.com>,
 Manivannan Sadhasivami <manivannan.sadhasivam@...aro.org>,
 linux-scsi@...r.kernel.org, "Martin K . Petersen"
 <martin.petersen@...cle.com>, Jaroslav Kysela <perex@...ex.cz>,
 linux-sound@...r.kernel.org, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, linux-usb@...r.kernel.org,
 linux-serial@...r.kernel.org, Hans de Goede <hdegoede@...hat.com>,
 platform-driver-x86@...r.kernel.org, ntb@...ts.linux.dev,
 Lee Jones <lee@...nel.org>, David Airlie <airlied@...il.com>,
 amd-gfx@...ts.freedesktop.org, Jason Gunthorpe <jgg@...pe.ca>,
 linux-rdma@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Cezary Rojewski <cezary.rojewski@...el.com>
Subject: Re: [PATCH 04/28] sound: intel: Use PCI_IRQ_INTX

On 3/25/2024 8:09 AM, Damien Le Moal wrote:
> Use the macro PCI_IRQ_INTX instead of the deprecated PCI_IRQ_LEGACY
> macro.
> 
> Signed-off-by: Damien Le Moal <dlemoal@...nel.org>
> ---
>   sound/soc/intel/avs/core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/intel/avs/core.c b/sound/soc/intel/avs/core.c
> index d7f8940099ce..69818e4b43da 100644
> --- a/sound/soc/intel/avs/core.c
> +++ b/sound/soc/intel/avs/core.c
> @@ -343,7 +343,7 @@ static int avs_hdac_acquire_irq(struct avs_dev *adev)
>   	int ret;
>   
>   	/* request one and check that we only got one interrupt */
> -	ret = pci_alloc_irq_vectors(pci, 1, 1, PCI_IRQ_MSI | PCI_IRQ_LEGACY);
> +	ret = pci_alloc_irq_vectors(pci, 1, 1, PCI_IRQ_MSI | PCI_IRQ_INTX);
>   	if (ret != 1) {
>   		dev_err(adev->dev, "Failed to allocate IRQ vector: %d\n", ret);
>   		return ret;

Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@...ux.intel.com>