linux-kernel - Re: [PATCH V3 net 1/3] net: hns3: fix index limit to support all queue stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fd2ff9ce-077e-4632-b515-f4b4c46b596a@huawei.com>
Date: Mon, 25 Mar 2024 20:55:56 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>
CC: <shaojijie@...wei.com>, <yisen.zhuang@...wei.com>,
	<salil.mehta@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <michal.kubiak@...el.com>,
	<rkannoth@...vell.com>, <shenjian15@...wei.com>, <wangjie125@...wei.com>,
	<liuyonglong@...wei.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3 net 1/3] net: hns3: fix index limit to support all
 queue stats


on 2024/3/18 22:36, Kalesh Anakkur Purayil wrote:
> On Mon, Mar 18, 2024 at 7:05 PM Jijie Shao <shaojijie@...wei.com> wrote:
>> From: Jie Wang <wangjie125@...wei.com>
>>
>> Currently, hns hardware supports more than 512 queues and the index limit
>> in hclge_comm_tqps_update_stats is wrong. So this patch removes it.
>>
>> Fixes: 287db5c40d15 ("net: hns3: create new set of common tqp stats APIs for PF and VF reuse")
>> Signed-off-by: Jie Wang <wangjie125@...wei.com>
>> Signed-off-by: Jijie Shao <shaojijie@...wei.com>
> Only question I have is whether this is a fix or an enhancement.
> Nevertheless changes look good to me.

Actually, it's a fix. The capability of supporting more than 512 queues 
was not implemented by modifying this statistics. this bug prevents us 
from querying the statistics of more than 512 queues.