| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <780d7dfb-3a91-4cd7-95a7-528877c9ad33@igalia.com>
Date: Mon, 25 Mar 2024 10:13:01 -0300
From: Maíra Canal <mcanal@...lia.com>
To: Louis Chauvet <louis.chauvet@...tlin.com>,
Rodrigo Siqueira <rodrigosiqueiramelo@...il.com>,
Melissa Wen <melissa.srw@...il.com>,
Haneen Mohammed <hamohammed.sa@...il.com>, Daniel Vetter <daniel@...ll.ch>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>, arthurgrillo@...eup.net,
Jonathan Corbet <corbet@....net>, pekka.paalanen@...oniitty.fi
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
jeremie.dautheribes@...tlin.com, miquel.raynal@...tlin.com,
thomas.petazzoni@...tlin.com, seanpaul@...gle.com, marcheu@...gle.com,
nicolejadeyee@...gle.com
Subject: Re: [PATCH v5 01/16] drm/vkms: Code formatting
On 3/13/24 14:44, Louis Chauvet wrote:
> Few no-op changes to remove double spaces and fix wrong alignments.
>
> Signed-off-by: Louis Chauvet <louis.chauvet@...tlin.com>
Reviewed-by: Maíra Canal <mcanal@...lia.com>
Best Regards,
- Maíra
> ---
> drivers/gpu/drm/vkms/vkms_composer.c | 10 +++++-----
> drivers/gpu/drm/vkms/vkms_crtc.c | 6 ++----
> drivers/gpu/drm/vkms/vkms_drv.c | 3 +--
> drivers/gpu/drm/vkms/vkms_plane.c | 8 ++++----
> 4 files changed, 12 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/vkms_composer.c
> index e7441b227b3c..c6d9b4a65809 100644
> --- a/drivers/gpu/drm/vkms/vkms_composer.c
> +++ b/drivers/gpu/drm/vkms/vkms_composer.c
> @@ -96,7 +96,7 @@ static u16 lerp_u16(u16 a, u16 b, s64 t)
> s64 a_fp = drm_int2fixp(a);
> s64 b_fp = drm_int2fixp(b);
>
> - s64 delta = drm_fixp_mul(b_fp - a_fp, t);
> + s64 delta = drm_fixp_mul(b_fp - a_fp, t);
>
> return drm_fixp2int(a_fp + delta);
> }
> @@ -302,8 +302,8 @@ static int compose_active_planes(struct vkms_writeback_job *active_wb,
> void vkms_composer_worker(struct work_struct *work)
> {
> struct vkms_crtc_state *crtc_state = container_of(work,
> - struct vkms_crtc_state,
> - composer_work);
> + struct vkms_crtc_state,
> + composer_work);
> struct drm_crtc *crtc = crtc_state->base.crtc;
> struct vkms_writeback_job *active_wb = crtc_state->active_writeback;
> struct vkms_output *out = drm_crtc_to_vkms_output(crtc);
> @@ -328,7 +328,7 @@ void vkms_composer_worker(struct work_struct *work)
> crtc_state->gamma_lut.base = (struct drm_color_lut *)crtc->state->gamma_lut->data;
> crtc_state->gamma_lut.lut_length =
> crtc->state->gamma_lut->length / sizeof(struct drm_color_lut);
> - max_lut_index_fp = drm_int2fixp(crtc_state->gamma_lut.lut_length - 1);
> + max_lut_index_fp = drm_int2fixp(crtc_state->gamma_lut.lut_length - 1);
> crtc_state->gamma_lut.channel_value2index_ratio = drm_fixp_div(max_lut_index_fp,
> u16_max_fp);
>
> @@ -367,7 +367,7 @@ void vkms_composer_worker(struct work_struct *work)
> drm_crtc_add_crc_entry(crtc, true, frame_start++, &crc32);
> }
>
> -static const char * const pipe_crc_sources[] = {"auto"};
> +static const char *const pipe_crc_sources[] = { "auto" };
>
> const char *const *vkms_get_crc_sources(struct drm_crtc *crtc,
> size_t *count)
> diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c
> index 61e500b8c9da..7586ae2e1dd3 100644
> --- a/drivers/gpu/drm/vkms/vkms_crtc.c
> +++ b/drivers/gpu/drm/vkms/vkms_crtc.c
> @@ -191,8 +191,7 @@ static int vkms_crtc_atomic_check(struct drm_crtc *crtc,
> return ret;
>
> drm_for_each_plane_mask(plane, crtc->dev, crtc_state->plane_mask) {
> - plane_state = drm_atomic_get_existing_plane_state(crtc_state->state,
> - plane);
> + plane_state = drm_atomic_get_existing_plane_state(crtc_state->state, plane);
> WARN_ON(!plane_state);
>
> if (!plane_state->visible)
> @@ -208,8 +207,7 @@ static int vkms_crtc_atomic_check(struct drm_crtc *crtc,
>
> i = 0;
> drm_for_each_plane_mask(plane, crtc->dev, crtc_state->plane_mask) {
> - plane_state = drm_atomic_get_existing_plane_state(crtc_state->state,
> - plane);
> + plane_state = drm_atomic_get_existing_plane_state(crtc_state->state, plane);
>
> if (!plane_state->visible)
> continue;
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> index dd0af086e7fa..83e6c9b9ff46 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.c
> +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> @@ -81,8 +81,7 @@ static void vkms_atomic_commit_tail(struct drm_atomic_state *old_state)
> drm_atomic_helper_wait_for_flip_done(dev, old_state);
>
> for_each_old_crtc_in_state(old_state, crtc, old_crtc_state, i) {
> - struct vkms_crtc_state *vkms_state =
> - to_vkms_crtc_state(old_crtc_state);
> + struct vkms_crtc_state *vkms_state = to_vkms_crtc_state(old_crtc_state);
>
> flush_work(&vkms_state->composer_work);
> }
> diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c
> index e5c625ab8e3e..5a8d295e65f2 100644
> --- a/drivers/gpu/drm/vkms/vkms_plane.c
> +++ b/drivers/gpu/drm/vkms/vkms_plane.c
> @@ -117,10 +117,10 @@ static void vkms_plane_atomic_update(struct drm_plane *plane,
> memcpy(&frame_info->map, &shadow_plane_state->data, sizeof(frame_info->map));
> drm_framebuffer_get(frame_info->fb);
> frame_info->rotation = drm_rotation_simplify(new_state->rotation, DRM_MODE_ROTATE_0 |
> - DRM_MODE_ROTATE_90 |
> - DRM_MODE_ROTATE_270 |
> - DRM_MODE_REFLECT_X |
> - DRM_MODE_REFLECT_Y);
> + DRM_MODE_ROTATE_90 |
> + DRM_MODE_ROTATE_270 |
> + DRM_MODE_REFLECT_X |
> + DRM_MODE_REFLECT_Y);
>
> drm_rect_rotate(&frame_info->rotated, drm_rect_width(&frame_info->rotated),
> drm_rect_height(&frame_info->rotated), frame_info->rotation);
>
Powered by blists - more mailing lists