[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <82e09104-8006-4074-9700-2dec08194ac4@linaro.org>
Date: Mon, 25 Mar 2024 14:59:10 +0100
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Jan Dakinevich <jan.dakinevich@...utedevices.com>,
Linus Walleij <linus.walleij@...aro.org>, Kevin Hilman
<khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] pinctrl/meson: fix typo in PDM's pin name
On 25/03/2024 12:30, Jan Dakinevich wrote:
> Other pins have _a or _x suffix, but this one doesn't have any. Most
> likely this is a typo.
>
> Fixes: dabad1ff8561 ("pinctrl: meson: add pinctrl driver support for Meson-A1 SoC")
> Signed-off-by: Jan Dakinevich <jan.dakinevich@...utedevices.com>
> ---
> Links:
>
> [1] https://lore.kernel.org/lkml/20240314232201.2102178-1-jan.dakinevich@salutedevices.com/
>
> Changes:
> v1 -> v2: Detached from v1's series (patch 15)
>
> drivers/pinctrl/meson/pinctrl-meson-a1.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-a1.c b/drivers/pinctrl/meson/pinctrl-meson-a1.c
> index 79f5d753d7e1..50a87d9618a8 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-a1.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-a1.c
> @@ -250,7 +250,7 @@ static const unsigned int pdm_dclk_x_pins[] = { GPIOX_10 };
> static const unsigned int pdm_din2_a_pins[] = { GPIOA_6 };
> static const unsigned int pdm_din1_a_pins[] = { GPIOA_7 };
> static const unsigned int pdm_din0_a_pins[] = { GPIOA_8 };
> -static const unsigned int pdm_dclk_pins[] = { GPIOA_9 };
> +static const unsigned int pdm_dclk_a_pins[] = { GPIOA_9 };
>
> /* gen_clk */
> static const unsigned int gen_clk_x_pins[] = { GPIOX_7 };
> @@ -591,7 +591,7 @@ static struct meson_pmx_group meson_a1_periphs_groups[] = {
> GROUP(pdm_din2_a, 3),
> GROUP(pdm_din1_a, 3),
> GROUP(pdm_din0_a, 3),
> - GROUP(pdm_dclk, 3),
> + GROUP(pdm_dclk_a, 3),
> GROUP(pwm_c_a, 3),
> GROUP(pwm_b_a, 3),
>
> @@ -755,7 +755,7 @@ static const char * const spi_a_groups[] = {
>
> static const char * const pdm_groups[] = {
> "pdm_din0_x", "pdm_din1_x", "pdm_din2_x", "pdm_dclk_x", "pdm_din2_a",
> - "pdm_din1_a", "pdm_din0_a", "pdm_dclk",
> + "pdm_din1_a", "pdm_din0_a", "pdm_dclk_a",
> };
>
> static const char * const gen_clk_groups[] = {
Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>
Powered by blists - more mailing lists