linux-kernel - Re: [PATCH v3 02/10] phy: rockchip: add usbdp combo phy driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6661610.4vTCxPXJkl@diego>
Date: Mon, 25 Mar 2024 15:19:42 +0100
From: Heiko Stübner <heiko@...ech.de>
To: Vinod Koul <vkoul@...nel.org>, Kishon Vijay Abraham I <kishon@...nel.org>,
 linux-rockchip@...ts.infradead.org, linux-phy@...ts.infradead.org,
 Sebastian Reichel <sebastian.reichel@...labora.com>
Cc: Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Frank Wang <frank.wang@...k-chips.com>,
 Kever Yang <kever.yang@...k-chips.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 Sebastian Reichel <sebastian.reichel@...labora.com>, kernel@...labora.com,
 Zhang Yubing <yubing.zhang@...k-chips.com>
Subject: Re: [PATCH v3 02/10] phy: rockchip: add usbdp combo phy driver

Hi Sebastian,

Am Montag, 25. März 2024, 15:17:26 CET schrieb Heiko Stübner:
> Am Freitag, 16. Februar 2024, 18:01:17 CET schrieb Sebastian Reichel:
> > This adds a new USBDP combo PHY with Samsung IP block driver.
> > 
> > The driver get lane mux and mapping info in 2 ways, supporting
> > DisplayPort alternate mode or parsing from DT. When parsing from DT,
> > the property "rockchip,dp-lane-mux" provide the DP mux and mapping
> > info. This is needed when the PHY is not used with TypeC Alt-Mode.
> > For example if the USB3 interface of the PHY is connected to a USB
> > Type A connector and the DP interface is connected to a DisplayPort
> > connector.
> > 
> > When do DP link training, need to set lane number, link rate, swing,
> > and pre-emphasis via PHY configure interface.
> > 
> > Co-developed-by: Heiko Stuebner <heiko@...ech.de>
> > Signed-off-by: Heiko Stuebner <heiko@...ech.de>
> > Co-developed-by: Zhang Yubing <yubing.zhang@...k-chips.com>
> > Signed-off-by: Zhang Yubing <yubing.zhang@...k-chips.com>
> > Co-developed-by: Frank Wang <frank.wang@...k-chips.com>
> > Signed-off-by: Frank Wang <frank.wang@...k-chips.com>
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>
> 
> after 6.9-rc1 this needs a respin with
> 
> diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rockchip/phy-rockchip-usbdp.c
> index 1f3b7955c9f3..38dc96cfe403 100644
> --- a/drivers/phy/rockchip/phy-rockchip-usbdp.c
> +++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c
> @@ -1420,7 +1420,7 @@ static const struct regmap_config rk_udphy_pma_regmap_cfg = {
>         .max_register = 0x20dc,
>  };
>  
> -static struct phy *rk_udphy_phy_xlate(struct device *dev, struct of_phandle_args *args)
> +static struct phy *rk_udphy_phy_xlate(struct device *dev, const struct of_phandle_args *args)
>  {
>         struct rk_udphy *udphy = dev_get_drvdata(dev);
>  
> 
> 
> to honor the change from
> commit 00ca8a15dafa ("phy: constify of_phandle_args in xlate")

and this "nicely" overlapped with you sending that v4, with said change
already included :-) .