linux-kernel - RE: [PATCH 10/28] drm: amdgpu: Use PCI_IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 25 Mar 2024 14:29:32 +0000
From: "Deucher, Alexander" <Alexander.Deucher@....com>
To: Damien Le Moal <dlemoal@...nel.org>, "linux-pci@...r.kernel.org"
	<linux-pci@...r.kernel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, Manivannan
 Sadhasivami <manivannan.sadhasivam@...aro.org>, "linux-scsi@...r.kernel.org"
	<linux-scsi@...r.kernel.org>, "Martin K . Petersen"
	<martin.petersen@...cle.com>, Jaroslav Kysela <perex@...ex.cz>,
	"linux-sound@...r.kernel.org" <linux-sound@...r.kernel.org>, Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>, "linux-usb@...r.kernel.org"
	<linux-usb@...r.kernel.org>, "linux-serial@...r.kernel.org"
	<linux-serial@...r.kernel.org>, Hans de Goede <hdegoede@...hat.com>,
	"platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>,
	"ntb@...ts.linux.dev" <ntb@...ts.linux.dev>, Lee Jones <lee@...nel.org>,
	David Airlie <airlied@...il.com>, "amd-gfx@...ts.freedesktop.org"
	<amd-gfx@...ts.freedesktop.org>, Jason Gunthorpe <jgg@...pe.ca>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>, "David S . Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 10/28] drm: amdgpu: Use PCI_IRQ_INTX

[Public]

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@...ts.freedesktop.org> On Behalf Of
> Damien Le Moal
> Sent: Monday, March 25, 2024 3:09 AM
> To: linux-pci@...r.kernel.org; Bjorn Helgaas <bhelgaas@...gle.com>;
> Manivannan Sadhasivami <manivannan.sadhasivam@...aro.org>; linux-
> scsi@...r.kernel.org; Martin K . Petersen <martin.petersen@...cle.com>;
> Jaroslav Kysela <perex@...ex.cz>; linux-sound@...r.kernel.org; Greg Kroah-
> Hartman <gregkh@...uxfoundation.org>; linux-usb@...r.kernel.org; linux-
> serial@...r.kernel.org; Hans de Goede <hdegoede@...hat.com>; platform-
> driver-x86@...r.kernel.org; ntb@...ts.linux.dev; Lee Jones <lee@...nel.org>;
> David Airlie <airlied@...il.com>; amd-gfx@...ts.freedesktop.org; Jason
> Gunthorpe <jgg@...pe.ca>; linux-rdma@...r.kernel.org; David S . Miller
> <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH 10/28] drm: amdgpu: Use PCI_IRQ_INTX
>
> Use the macro PCI_IRQ_INTX instead of the deprecated PCI_IRQ_LEGACY
> macro.
>
> Signed-off-by: Damien Le Moal <dlemoal@...nel.org>

Feel free to take it through whatever tree makes sense.  If you want me to pick it up, let me know.
Acked-by: Alex Deucher <alexander.deucher@....com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> index 7e6d09730e6d..d18113017ee7 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> @@ -279,7 +279,7 @@ int amdgpu_irq_init(struct amdgpu_device *adev)
>       adev->irq.msi_enabled = false;
>
>       if (!amdgpu_msi_ok(adev))
> -             flags = PCI_IRQ_LEGACY;
> +             flags = PCI_IRQ_INTX;
>       else
>               flags = PCI_IRQ_ALL_TYPES;
>
> --
> 2.44.0