linux-kernel - Re: [PATCH v6 04/16] dt-bindings: net: wireless: qcom,ath11k: describe the ath11k on QCA6390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87frwe8jiu.fsf@kernel.org>
Date: Mon, 25 Mar 2024 16:37:29 +0200
From: Kalle Valo <kvalo@...nel.org>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Marcel Holtmann <marcel@...tmann.org>,  Luiz Augusto von Dentz
 <luiz.dentz@...il.com>,  "David S . Miller" <davem@...emloft.net>,  Eric
 Dumazet <edumazet@...gle.com>,  Jakub Kicinski <kuba@...nel.org>,  Paolo
 Abeni <pabeni@...hat.com>,  Rob Herring <robh@...nel.org>,  Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@...aro.org>,  Conor Dooley
 <conor+dt@...nel.org>,  Bjorn Andersson <andersson@...nel.org>,  Konrad
 Dybcio <konrad.dybcio@...aro.org>,  Liam Girdwood <lgirdwood@...il.com>,
  Mark Brown <broonie@...nel.org>,  Catalin Marinas
 <catalin.marinas@....com>,  Will Deacon <will@...nel.org>,  Bjorn Helgaas
 <bhelgaas@...gle.com>,  Saravana Kannan <saravanak@...gle.com>,  Geert
 Uytterhoeven <geert+renesas@...der.be>,  Arnd Bergmann <arnd@...db.de>,
  Neil Armstrong <neil.armstrong@...aro.org>,  Marek Szyprowski
 <m.szyprowski@...sung.com>,  Alex Elder <elder@...aro.org>,  Srini
 Kandagatla <srinivas.kandagatla@...aro.org>,  Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>,  Abel Vesa <abel.vesa@...aro.org>,
  Manivannan Sadhasivam <mani@...nel.org>,  Lukas Wunner <lukas@...ner.de>,
  Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
  linux-bluetooth@...r.kernel.org,  netdev@...r.kernel.org,
  devicetree@...r.kernel.org,  linux-kernel@...r.kernel.org,
  linux-wireless@...r.kernel.org,  linux-arm-msm@...r.kernel.org,
  linux-arm-kernel@...ts.infradead.org,  linux-pci@...r.kernel.org,
  linux-pm@...r.kernel.org,  Bartosz Golaszewski
 <bartosz.golaszewski@...aro.org>,
    ath11k@...ts.infradead.org, Johan Hovold <johan@...nel.org>
Subject: Re: [PATCH v6 04/16] dt-bindings: net: wireless: qcom,ath11k:
 describe the ath11k on QCA6390

Bartosz Golaszewski <brgl@...ev.pl> writes:

> On Mon, Mar 25, 2024 at 2:57 PM Kalle Valo <kvalo@...nel.org> wrote:
>
>>
>> Bartosz Golaszewski <brgl@...ev.pl> writes:
>>
>> > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>> >
>> > Add a PCI compatible for the ATH11K module on QCA6390 and describe the
>> > power inputs from the PMU that it consumes.
>> >
>> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>>
>> [...]
>>
>> > +allOf:
>> > +  - if:
>> > +      properties:
>> > +        compatible:
>> > +          contains:
>> > +            const: pci17cb,1101
>> > +    then:
>> > +      required:
>> > +        - vddrfacmn-supply
>> > +        - vddaon-supply
>> > +        - vddwlcx-supply
>> > +        - vddwlmx-supply
>> > +        - vddrfa0p8-supply
>> > +        - vddrfa1p2-supply
>> > +        - vddrfa1p7-supply
>> > +        - vddpcie0p9-supply
>> > +        - vddpcie1p8-supply
>>
>> I don't know DT well enough to know what the "required:" above means,
>> but does this take into account that there are normal "plug&play" type
>> of QCA6390 boards as well which don't need any DT settings?
>
> Do they require a DT node though for some reason?

You can attach the device to any PCI slot, connect the WLAN antenna and
it just works without DT nodes. I'm trying to make sure here that basic
setup still works.

Adding also Johan and ath11k list. For example, I don't know what's the
plan with Lenovo X13s, will it use this framework? I guess in theory we
could have devices which use qcom,ath11k-calibration-variant from DT but
not any of these supply properties?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches