linux-kernel - Re: [PATCH v5 2/2] hwmon: (acpi_power_meter) Ensure IPMI space handler is ready on Dell systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4ac8a198-b0c9-418e-bcf8-1ee1a9660dad@roeck-us.net>
Date: Mon, 25 Mar 2024 07:40:03 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Andy Shevchenko <andy@...ck.fi.intel.com>,
 Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc: rafael@...nel.org, lenb@...nel.org, jdelvare@...e.com,
 robert.moore@...el.com, linux-acpi@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
 acpica-devel@...ts.linux.dev
Subject: Re: [PATCH v5 2/2] hwmon: (acpi_power_meter) Ensure IPMI space
 handler is ready on Dell systems

On 3/25/24 05:38, Andy Shevchenko wrote:
> On Wed, Mar 20, 2024 at 04:43:17PM +0800, Kai-Heng Feng wrote:
>> The following error can be observed at boot:
>> [    3.717920] ACPI Error: No handler for Region [SYSI] (00000000ab9e62c5) [IPMI] (20230628/evregion-130)
>> [    3.717928] ACPI Error: Region IPMI (ID=7) has no handler (20230628/exfldio-261)
>>
>> [    3.717936] No Local Variables are initialized for Method [_GHL]
>>
>> [    3.717938] No Arguments are initialized for method [_GHL]
>>
>> [    3.717940] ACPI Error: Aborting method \_SB.PMI0._GHL due to previous error (AE_NOT_EXIST) (20230628/psparse-529)
>> [    3.717949] ACPI Error: Aborting method \_SB.PMI0._PMC due to previous error (AE_NOT_EXIST) (20230628/psparse-529)
>> [    3.717957] ACPI: \_SB_.PMI0: _PMC evaluation failed: AE_NOT_EXIST
>>
>> On Dell systems several methods of acpi_power_meter access variables in
>> IPMI region [0], so wait until IPMI space handler is installed by
>> acpi_ipmi and also wait until SMI is selected to make the space handler
>> fully functional.
>>
>> Since the dependency is inside BIOS's ASL code and it's not
>> discoverable, so use this fixup is a hack to workaround BIOS issue.
> 
> ...
> 
>> +	if (dmi_match(DMI_SYS_VENDOR, "Dell Inc.")) {
>> +		ipi_device = acpi_dev_get_first_match_dev("IPI0001", NULL, -1);
>> +
>> +		if (ipi_device) {
>> +			if (acpi_wait_for_acpi_ipmi())
>> +				dev_warn(&device->dev, "Waiting for ACPI IPMI timeout");
>> +			acpi_dev_put(ipi_device);
>> +		}
> 
> Can be written as
> 
> 	if (dmi_match(DMI_SYS_VENDOR, "Dell Inc.")) {
> 		ipi_device = acpi_dev_get_first_match_dev("IPI0001", NULL, -1);
> 		if (ipi_device && acpi_wait_for_acpi_ipmi())
> 			dev_warn(&device->dev, "Waiting for ACPI IPMI timeout");
> 		acpi_dev_put(ipi_device);
> 
>> +	}
> 

Ah yes, acpi_dev_put() checks if the parameter is NULL. Good point.
I'll make that change, no need to resend.

Thanks,
Guenter