linux-kernel - Re: [PATCH v1 1/1] mtd: core: Align comment with an action in mtd_otp_nvmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZgGYDMzAWEaPkAXh@smile.fi.intel.com>
Date: Mon, 25 Mar 2024 17:28:12 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc: Miquel Raynal <miquel.raynal@...tlin.com>,
	Richard Weinberger <richard@....at>,
	Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH v1 1/1] mtd: core: Align comment with an action in
 mtd_otp_nvmem_add()

On Mon, Mar 25, 2024 at 05:11:50PM +0200, Andy Shevchenko wrote:
> The comment is related to the non-error case, make it more clear
> by inverting the condition. It also makes code neater at the end.

Just realized that even semantically it's better as it's done here
since we have an error path from which we exceptionally return successes
(in some cases). Tell me if I need to add this to the commit message.

-- 
With Best Regards,
Andy Shevchenko