linux-kernel - Re: [PATCH 08/28] ntb: Use PCI_IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 25 Mar 2024 08:52:11 -0700
From: Dave Jiang <dave.jiang@...el.com>
To: Damien Le Moal <dlemoal@...nel.org>, linux-pci@...r.kernel.org,
 Bjorn Helgaas <bhelgaas@...gle.com>,
 Manivannan Sadhasivami <manivannan.sadhasivam@...aro.org>,
 linux-scsi@...r.kernel.org, "Martin K . Petersen"
 <martin.petersen@...cle.com>, Jaroslav Kysela <perex@...ex.cz>,
 linux-sound@...r.kernel.org, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, linux-usb@...r.kernel.org,
 linux-serial@...r.kernel.org, Hans de Goede <hdegoede@...hat.com>,
 platform-driver-x86@...r.kernel.org, ntb@...ts.linux.dev,
 Lee Jones <lee@...nel.org>, David Airlie <airlied@...il.com>,
 amd-gfx@...ts.freedesktop.org, Jason Gunthorpe <jgg@...pe.ca>,
 linux-rdma@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/28] ntb: Use PCI_IRQ_INTX

On 3/25/24 12:09 AM, Damien Le Moal wrote:
> Use the macro PCI_IRQ_INTX instead of the deprecated PCI_IRQ_LEGACY
> macro.
> 
> Signed-off-by: Damien Le Moal <dlemoal@...nel.org>

Reviewed-by: Dave Jiang <dave.jiang@...el.com>

> ---
>  drivers/ntb/hw/idt/ntb_hw_idt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ntb/hw/idt/ntb_hw_idt.c b/drivers/ntb/hw/idt/ntb_hw_idt.c
> index 48823b53ede3..48dfb1a69a77 100644
> --- a/drivers/ntb/hw/idt/ntb_hw_idt.c
> +++ b/drivers/ntb/hw/idt/ntb_hw_idt.c
> @@ -2129,7 +2129,7 @@ static int idt_init_isr(struct idt_ntb_dev *ndev)
>  	int ret;
>  
>  	/* Allocate just one interrupt vector for the ISR */
> -	ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_MSI | PCI_IRQ_LEGACY);
> +	ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_MSI | PCI_IRQ_INTX);
>  	if (ret != 1) {
>  		dev_err(&pdev->dev, "Failed to allocate IRQ vector");
>  		return ret;