linux-kernel - Re: [PATCH v1 1/3] hwmon: (pmbus/mp2975) Replace home made version of __assign

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 25 Mar 2024 18:34:13 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Guenter Roeck <linux@...ck-us.net>
Cc: Patrick Rudolph <patrick.rudolph@...ements.com>,
	linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jean Delvare <jdelvare@...e.com>
Subject: Re: [PATCH v1 1/3] hwmon: (pmbus/mp2975) Replace home made version
 of __assign_bit()

On Mon, Mar 25, 2024 at 09:29:11AM -0700, Guenter Roeck wrote:
> On Mon, Mar 25, 2024 at 02:07:42PM +0200, Andy Shevchenko wrote:
> > The newly introduced SWAP() macro is quite generic by naming, but
> > moreover it's a repetition of the existing __assign_bit().
> > With this applied, add a missing bits.h (via now required bitops.h).
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> Not sure if I like __assign_bit() more than SWAP(),

To add to the mess, we have swap() already defined globally.
This one steps on our toes.

> but at least it is "standard". Applied.

Thank you!

-- 
With Best Regards,
Andy Shevchenko