[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZgG1LwVAd1xxqJTg@smile.fi.intel.com>
Date: Mon, 25 Mar 2024 19:32:31 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Mark Brown <broonie@...nel.org>
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
Liam Girdwood <lgirdwood@...il.com>,
Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH v1 1/1] ASoC: soc-jack: Get rid of legacy GPIO support
On Mon, Mar 25, 2024 at 05:22:55PM +0000, Mark Brown wrote:
> On Mon, Mar 25, 2024 at 04:24:19PM +0200, Andy Shevchenko wrote:
> > On Mon, Mar 25, 2024 at 02:16:15PM +0000, Mark Brown wrote:
> > > On Mon, Mar 18, 2024 at 10:25:16PM +0200, Andy Shevchenko wrote:
..
> > > > If I am not mistaken, after
> > > > https://lore.kernel.org/r/20240318200804.181516-1-andriy.shevchenko@linux.intel.com
> > > > there is no more users. Hence the above is the only dependency.
>
> > > You are mistaken, please try compile tests:
..
> > > (this is among other things in x86 allmodconfig).
>
> > I usually enable the particular drivers and I have compile tested this,
> > but indeed, I haven't enabled _all_ modules.
>
> > Thank you for the pointing out.
>
> Especially if you're doing this sort of "I think I got everything" type
> change it's sensible to do at least one allmodconfig build, it won't get
> everything but it'll catch a lot.
True, as even `git grep` output can be misinterpreted and some occurrences
may disappear from the sight.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists