[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <35355d02-3eef-4860-847b-b7bbf05f4a31@moroto.mountain>
Date: Mon, 25 Mar 2024 21:28:32 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Johannes Berg <johannes@...solutions.net>
Cc: Boqun Feng <boqun.feng@...il.com>, rcu@...r.kernel.org,
linux-kernel@...r.kernel.org,
"Paul E. McKenney" <paulmck@...nel.org>,
Frederic Weisbecker <frederic@...nel.org>,
Josh Triplett <josh@...htriplett.org>,
Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH] rcu: mollify sparse with RCU guard
On Mon, Mar 25, 2024 at 05:41:22PM +0100, Johannes Berg wrote:
> Also __acquire()/__release() are just empty macros without __CHECKER__.
> So not sure the indirection really is warranted for this special case.
>
> I can add a comment in there, I guess, something like
>
> /* sparse doesn't actually "call" cleanup functions */
>
> perhaps. That reminds me I forgot to CC Dan ...
>
These are Sparse warnings, not Smatch warning... Smatch doesn't use any
of the Sparse locking annotations. Smatch handles cleanup basically
correctly at this point.
regards,
dan carpenter
Powered by blists - more mailing lists