linux-kernel - Re: [PATCH v1 1/1] ASoC: soc-jack: Get rid of legacy GPIO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e6900b97-c1b7-45a5-bc3c-4a4a2745fdf3@sirena.org.uk>
Date: Mon, 25 Mar 2024 14:16:15 +0000
From: Mark Brown <broonie@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH v1 1/1] ASoC: soc-jack: Get rid of legacy GPIO support

On Mon, Mar 18, 2024 at 10:25:16PM +0200, Andy Shevchenko wrote:
> No more users.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  include/sound/soc-jack.h |  2 --
> 
> If I am not mistaken, after
> https://lore.kernel.org/r/20240318200804.181516-1-andriy.shevchenko@linux.intel.com
> there is no more users. Hence the above is the only dependency.

You are mistaken, please try compile tests:

/build/stage/linux/sound/soc/generic/simple-card-utils.c: In function ‘simple_util_init_jack’:
/build/stage/linux/sound/soc/generic/simple-card-utils.c:755:20: error: ‘struct snd_soc_jack_gpio’ has no member named ‘gpio’
  755 |         sjack->gpio.gpio = -ENOENT;
      |                    ^

(this is among other things in x86 allmodconfig).

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)