lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 25 Mar 2024 20:30:16 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Kartik Agarwala <agarwala.kartik@...il.com>, lgirdwood@...il.com,
 broonie@...nel.org, robh@...nel.org, krzysztof.kozlowski+dt@...aro.org,
 conor+dt@...nel.org
Cc: patches@...nsource.cirrus.com, linux-sound@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 javier.carrasco.cruz@...il.com
Subject: Re: [PATCH] ASoC: dt-bindings: wm8974: Convert to dtschema

On 25/03/2024 19:19, Kartik Agarwala wrote:
> Convert WM8974 audio CODEC bindings from text to dtschema.
> 
> Signed-off-by: Kartik Agarwala <agarwala.kartik@...il.com>

Thank you for your patch. There are no DTS users of this binding, so
while such conversions are useful, they have significantly smaller
impact. In the future, please consider converting bindings from active
platforms (arm64 defconfig, arm multi_v7). This would have significantly
bigger impact.

See also:
https://lore.kernel.org/all/6552bcb8-e046-4882-91da-1094fff3d239@linaro.org/

> ---
>  .../devicetree/bindings/sound/wlf,wm8974.txt  | 15 -------
>  .../devicetree/bindings/sound/wlf,wm8974.yaml | 41 +++++++++++++++++++
>  2 files changed, 41 insertions(+), 15 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8974.txt
>  create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8974.yaml
> 

..

> +  "#sound-dai-cells":
> +    const: 0
> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        codec@1a {
> +            compatible = "wlf,wm8974";
> +            reg = <0x1a>;

In the future for other patches like this, make example complete, so add
a dai-cells also here.

No need to resend just for that.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ