linux-kernel - Re: [PATCH v3] staging: bcm2835-audio: add terminating new line to Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 25 Mar 2024 22:42:35 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: Prasad Pandit <ppandit@...hat.com>, florian.fainelli@...adcom.com,
	bcm-kernel-feedback-list@...adcom.com,
	linux-arm-kernel@...ts.infradead.org, rjui@...adcom.com,
	sbranden@...adcom.com, linux-staging@...ts.linux.dev,
	linux-rpi-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Prasad Pandit <pjp@...oraproject.org>
Subject: Re: [PATCH v3] staging: bcm2835-audio: add terminating new line to
 Kconfig

On Mon, Mar 25, 2024 at 07:04:15PM +0100, Greg KH wrote:
> On Wed, Mar 13, 2024 at 05:11:26PM +0530, Prasad Pandit wrote:
> > From: Prasad Pandit <pjp@...oraproject.org>
> > 
> > Add terminating new line to the Kconfig file. It helps
> > Kconfig parsers to read file without error.
> 
> What in-tree parser has a problem with this file as-is?  If it's an
> out-of-tree parser, that's different, and the tool should be fixed, no
> need to touch the kernel files for no good reason.

It's annoying to cat a file when it doesn't have a newline on the end...

dcarpenter@...oto:~/progs/kernel/trees$ cat -n drivers/staging/vc04_services/bcm2835-audio/Kconfig
     1  # SPDX-License-Identifier: GPL-2.0
     2  config SND_BCM2835
     3          tristate "BCM2835 Audio"
     4          depends on (ARCH_BCM2835 || COMPILE_TEST) && SND
     5          select SND_PCM
     6          select BCM2835_VCHIQ if HAS_DMA
     7          help
     8            Say Y or M if you want to support BCM2835 built in audio.
     9            This driver handles both 3.5mm and HDMI audio, by leveraging
    10            the VCHIQ messaging interface between the kernel and the firmware
    11            running on VideoCore.dcarpenter@...oto:~/progs/kernel/trees$
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

So you could resend with that as a justification.  But, yeah, it's a
good idea to fix the tool as well.

regards,
dan carpenter