linux-kernel - Re: [PATCH v3] selftests/mm: Fix ARM related issue with fork after pthread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240325130426.fba5287fcc437475123e76cc@linux-foundation.org>
Date: Mon, 25 Mar 2024 13:04:26 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Edward Liaw <edliaw@...gle.com>
Cc: linux-kernel@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>, John Fastabend
 <john.fastabend@...il.com>, Andrii Nakryiko <andrii@...nel.org>, Martin
 KaFai Lau <martin.lau@...ux.dev>, Eduard Zingerman <eddyz87@...il.com>,
 Song Liu <song@...nel.org>, Yonghong Song <yonghong.song@...ux.dev>, KP
 Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...gle.com>, Hao Luo
 <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Shuah Khan
 <shuah@...nel.org>, Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers
 <ndesaulniers@...gle.com>, Bill Wendling <morbo@...gle.com>, Justin Stitt
 <justinstitt@...gle.com>, Jann Horn <jannh@...gle.com>,
 linux-kselftest@...r.kernel.org, kernel-team@...roid.com, Lokesh Gidra
 <lokeshgidra@...gle.com>, bpf@...r.kernel.org, netdev@...r.kernel.org,
 linux-mm@...ck.org, llvm@...ts.linux.dev, Peter Xu <peterx@...hat.com>
Subject: Re: [PATCH v3] selftests/mm: Fix ARM related issue with fork after
 pthread_create

On Mon, 25 Mar 2024 19:40:52 +0000 Edward Liaw <edliaw@...gle.com> wrote:

> Following issue was observed while running the uffd-unit-tests selftest
> on ARM devices. On x86_64 no issues were detected:
> 
> pthread_create followed by fork caused deadlock in certain cases
> wherein fork required some work to be completed by the created thread.
> Used synchronization to ensure that created thread's start function has
> started before invoking fork.

hm, you cc'ed the whole world apart from peterx.  Fixed.

> Signed-off-by: Lokesh Gidra <lokeshgidra@...gle.com>
> [edliaw: Refactored to use atomic_bool]
> Signed-off-by: Edward Liaw <edliaw@...gle.com>

I'll add cc:stable.  For which a Fixes: is desirable.  I used
760aee0b71e3 ("selftests/mm: add tests for RO pinning vs fork()"),
please check that.