linux-kernel - Re: [PATCH v2 RESEND] mm/mmap: convert all mas except mas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240325202648.ogekznob5vsayd6k@revolver>
Date: Mon, 25 Mar 2024 16:26:48 -0400
From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
To: Helge Deller <deller@....de>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
        Yajun Deng <yajun.deng@...ux.dev>, vbabka@...e.cz, lstoakes@...il.com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 RESEND] mm/mmap: convert all mas except mas_detach to
 vma iterator

* Helge Deller <deller@....de> [240325 16:24]:
> On 3/25/24 19:53, Andrew Morton wrote:
> > On Mon, 25 Mar 2024 14:32:58 +0800 Yajun Deng <yajun.deng@...ux.dev> wrote:
> > 
> > > There are two types of iterators mas and vmi in the current code. If the
> > > maple tree comes from the mm structure, we can use the vma iterator. Avoid
> > > using mas directly as possible.
> > > 
> > > Keep using mas for the mt_detach tree, since it doesn't come from the mm
> > > structure.
> > > 
> > > Remove as many uses of mas as possible, but we will still have a few that
> > > must be passed through in unmap_vmas() and free_pgtables().
> > > 
> > > Also introduce vma_iter_reset, vma_iter_{prev, next}_range_limit and
> > > vma_iter_area_{lowest, highest} helper functions for using the vma
> > > interator.
> > > 
> > 
> > I assume Liam's earlier request still applies?
> > 
> > : Helge,
> > :
> > : Yajun has changed code that affects parisc with this patch, which hasn't
> > : been tested.
> > : ...
> > : Can you make sure that the expand_upwards() still functions on parisc?
> 
> Oh, I didn't noticed that request earlier.
> Anyway, I now tested this patch on top of 6.9-rc1, and the kernel still
> boots up nicely on parisc and as such expand_upwards() seem to work as before.
> So, you may add:
> 
> Tested-by: Helge Deller <deller@....de> # parisc

Thanks Helge!

Reviewed-by: Liam R. Howlett <Liam.Howlett@...cle.com>