linux-kernel - Re: [PATCH 0/3] wifi: nl80211: fix nl80211 UAPI kernel-doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87h6gu1gv8.fsf@kernel.org>
Date: Mon, 25 Mar 2024 17:16:43 +0200
From: Kalle Valo <kvalo@...nel.org>
To: Jeff Johnson <quic_jjohnson@...cinc.com>
Cc: Johannes Berg <johannes@...solutions.net>,
  <linux-wireless@...r.kernel.org>,  <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/3] wifi: nl80211: fix nl80211 UAPI kernel-doc

Jeff Johnson <quic_jjohnson@...cinc.com> writes:

> On 3/20/2024 12:07 AM, Johannes Berg wrote:
>> On Tue, 2024-03-19 at 11:26 -0700, Jeff Johnson wrote:
>>> As part of my review of patches coming from the Qualcomm Innovation
>>> Center I check to make sure that no checkpatch or kernel-doc issues
>>> are introduced. An upcoming patch will propose a modification to
>>> include/uapi/linux/nl80211.h. My review process flagged both
>>> checkpatch and kernel-doc issues in the file, but these are
>>> pre-existing issues. So this series fixes those pre-existing issues.
>>>
>> 
>> Thanks Jeff.
>> 
>> Can you say what you're running for this? I've been running kernel-doc
>> and builds with W=1 for a long time, and not seen issues. Is this
>> perhaps checks from a newer kernel (we're currently on 6.8-rc1 for
>> $reasons)?
>
> files=$(git diff --name-only $base HEAD)
> scripts/kernel-doc -Werror -none $files
> scripts/checkpatch.pl --file $files

Thanks. So my plan is to run this in my check script:

scripts/kernel-doc -none \
include/linux/ieee80211.h \
include/net/cfg80211.h \
include/net/ieee80211_radiotap.h \
include/net/iw_handler.h \
include/net/wext.h \
include/uapi/linux/nl80211.h \
include/uapi/linux/wireless.h \
include/net/mac80211.h \
include/linux/rfkill.h \
include/uapi/linux/rfkill.h

Did I miss anything important?

Although include/linux/rfkill.h has three warnings:

include/linux/rfkill.h:104: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
 * rfkill_pause_polling(struct rfkill *rfkill)
include/linux/rfkill.h:114: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
 * rfkill_resume_polling(struct rfkill *rfkill)
include/linux/rfkill.h:331: warning: Function parameter or struct member 'rfkill' not described in 'rfkill_get_led_trigger_name'

Any volunteers to fix those? :)

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches