linux-kernel - RE: [PATCH rdma-next v2 4/4] RDMA/mana_ib: Use struct mana_ib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 25 Mar 2024 20:57:36 +0000
From: Konstantin Taranov <kotaranov@...rosoft.com>
To: Long Li <longli@...rosoft.com>, Konstantin Taranov
	<kotaranov@...ux.microsoft.com>, "sharmaajay@...rosoft.com"
	<sharmaajay@...rosoft.com>, "jgg@...pe.ca" <jgg@...pe.ca>, "leon@...nel.org"
	<leon@...nel.org>
CC: "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH rdma-next v2 4/4] RDMA/mana_ib: Use struct mana_ib_queue
 for RAW QPs

> From: Long Li <longli@...rosoft.com>
> Subject: RE: [PATCH rdma-next v2 4/4] RDMA/mana_ib: Use struct
> mana_ib_queue for RAW QPs
> 
> >  struct mana_ib_qp {
> >  	struct ib_qp ibqp;
> >
> > -	/* Work queue info */
> > -	struct ib_umem *sq_umem;
> > -	int sqe;
> > -	u64 sq_gdma_region;
> > -	u64 sq_id;
> > -	mana_handle_t tx_object;
> > +	struct mana_ib_raw_sq sq;
> 
> Are you planning to add another type of sq for RC here?
> 

There will be no more SQs. There will be rc_qp, ud_qp, uc_qp, which have several queues inside.
Should I still rename "struct mana_ib_raw_sq sq;" to "struct mana_ib_raw_sq raw_sq;" ?

Konstantin
> If yes, use raw_sq and rc_sq in struct fields.
> 
> Long