linux-kernel - Re: [PATCH v4 05/15] KVM: SEV: publish supported VMSA features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240325235918.GR2357401@ls.amr.corp.intel.com>
Date: Mon, 25 Mar 2024 16:59:18 -0700
From: Isaku Yamahata <isaku.yamahata@...el.com>
To: Paolo Bonzini <pbonzini@...hat.com>
Cc: linux-kernel@...r.kernel.org, kvm@...r.kernel.org, michael.roth@....com,
	isaku.yamahata@...el.com, seanjc@...gle.com,
	isaku.yamahata@...ux.intel.com, rick.p.edgecombe@...el.com,
	xiaoyao.li@...el.com, kai.huang@...el.com
Subject: Re: [PATCH v4 05/15] KVM: SEV: publish supported VMSA features

On Mon, Mar 18, 2024 at 07:33:42PM -0400,
Paolo Bonzini <pbonzini@...hat.com> wrote:

> Compute the set of features to be stored in the VMSA when KVM is
> initialized; move it from there into kvm_sev_info when SEV is initialized,
> and then into the initial VMSA.
> 
> The new variable can then be used to return the set of supported features
> to userspace, via the KVM_GET_DEVICE_ATTR ioctl.

Hi. The current TDX KVM introduces KVM_TDX_CAPABILITIES and struct
kvm_tdx_capabilities for feature enumeration.  I'm wondering if TDX should also
use/switch to KVM_GET_DEVICE_ATTR with its own group.  What do you think?
Something like

#define KVM_DEVICE_ATTR_GROUP_SEV       1
#define KVM_X86_SEV_VMSA_FEATURES       1
#define KVM_X86_SEV_xxx                 ...

#define KVM_DEVICE_ATTR_GROUP_TDX       2
#define KVM_X86_TDX_xxx                 ...

Thanks,
-- 
Isaku Yamahata <isaku.yamahata@...el.com>