linux-kernel - Re: [EXTERNAL] Re: [PATCH v11] ASoc: tas2783: Add tas2783 codec driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 26 Mar 2024 10:00:19 -0500
From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To: "Ding, Shenghao" <shenghao-ding@...com>,
 "broonie@...nel.org" <broonie@...nel.org>
Cc: "andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>,
 "lgirdwood@...il.com" <lgirdwood@...il.com>, "perex@...ex.cz"
 <perex@...ex.cz>, "13916275206@....com" <13916275206@....com>,
 "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "liam.r.girdwood@...el.com" <liam.r.girdwood@...el.com>,
 "bard.liao@...el.com" <bard.liao@...el.com>,
 "mengdong.lin@...el.com" <mengdong.lin@...el.com>,
 "yung-chuan.liao@...ux.intel.com" <yung-chuan.liao@...ux.intel.com>,
 "Lu, Kevin" <kevin-lu@...com>, "tiwai@...e.de" <tiwai@...e.de>,
 "Xu, Baojun" <baojun.xu@...com>, "soyer@....hu" <soyer@....hu>,
 "Baojun.Xu@....com" <Baojun.Xu@....com>,
 "Navada Kanyana, Mukund" <navada@...com>
Subject: Re: [EXTERNAL] Re: [PATCH v11] ASoc: tas2783: Add tas2783 codec
 driver


>>> +
>>> +	/* Check Calibrated Data V2 */
>>> +	if (tmp_val[0] == 2783) {
>>> +		const struct calibdatav2_info calib_info = {
>>> +			.number_of_devices = tmp_val[1],
>>> +			.crc32_indx = 3 + tmp_val[1] * 6,
>>> +			.byt_sz = 12 + tmp_val[1] * 24,
>>> +			.cali_data = &tmp_val[3]
>>> +		};
>>> +
>>> +		if (calib_info.number_of_devices >
>> TAS2783_MAX_DEV_NUM ||
>>> +			calib_info.number_of_devices == 0) {
>>> +			dev_dbg(tas_dev->dev, "No dev in calibrated data
>> V2.");
>>
>> the log is not aligned with the first condition where you have too many
>> devices.
>>
>> It's not clear why it's not an error.
> playback still work without calibrated data stored in UEFI, for example bypass mode.
> Even if in case of bypass mode, algo can still work with default calibrated data.
> So, not an error.

I would use a dev_info with a clearer message that defaults are used,
e.g. along the lines of

dev_info(tas_dev->dev, "using default calibration data, no device found
in EFI data v2").

dev_warn would work as well if this is really not expected.