linux-kernel - Re: [PATCH 06/12] nouveau: fix function cast warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ddd9519fa51f95eb14a6dd3f2a4b7d67ae7e47a9.camel@nvidia.com>
Date: Tue, 26 Mar 2024 15:20:18 +0000
From: Timur Tabi <ttabi@...dia.com>
To: "masahiroy@...nel.org" <masahiroy@...nel.org>, "kherbst@...hat.com"
	<kherbst@...hat.com>, "linux-kbuild@...r.kernel.org"
	<linux-kbuild@...r.kernel.org>, "arnd@...nel.org" <arnd@...nel.org>,
	"lyude@...hat.com" <lyude@...hat.com>, "bskeggs@...hat.com"
	<bskeggs@...hat.com>, "airlied@...il.com" <airlied@...il.com>,
	"dakr@...hat.com" <dakr@...hat.com>, "nathan@...nel.org" <nathan@...nel.org>,
	"daniel@...ll.ch" <daniel@...ll.ch>
CC: "justinstitt@...gle.com" <justinstitt@...gle.com>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"morbo@...gle.com" <morbo@...gle.com>, "nouveau@...ts.freedesktop.org"
	<nouveau@...ts.freedesktop.org>, "arnd@...db.de" <arnd@...db.de>,
	"nicolas@...sle.eu" <nicolas@...sle.eu>, "ndesaulniers@...gle.com"
	<ndesaulniers@...gle.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "llvm@...ts.linux.dev" <llvm@...ts.linux.dev>
Subject: Re: [PATCH 06/12] nouveau: fix function cast warning

On Tue, 2024-03-26 at 15:51 +0100, Arnd Bergmann wrote:
> Calling a function through an incompatible pointer type causes breaks
> kcfi, so clang warns about the assignment:
> 

...

> +static void of_fini(void *p)
> +{
> +       return kfree(p);
> +}
> +

I don't know anything about kfci, but shouldn't this just be "kfree(p)",
without the "return"?