linux-kernel - Re: [net Patch] octeontx2-af: Fix issue with loading coalesced KPU profiles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH-L+nOcb+EDx6ofMn+5pwQHZDMauCcjqjjKg9-8jSS1LUB9QA@mail.gmail.com>
Date: Tue, 26 Mar 2024 21:23:14 +0530
From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>
To: Hariprasad Kelam <hkelam@...vell.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kuba@...nel.org, 
	davem@...emloft.net, sgoutham@...vell.com, gakula@...vell.com, 
	jerinj@...vell.com, lcherian@...vell.com, sbhatta@...vell.com, 
	naveenm@...vell.com, edumazet@...gle.com, pabeni@...hat.com
Subject: Re: [net Patch] octeontx2-af: Fix issue with loading coalesced KPU profiles

On Tue, Mar 26, 2024 at 5:53 PM Hariprasad Kelam <hkelam@...vell.com> wrote:
>
> The current implementation for loading coalesced KPU profiles has
> a limitation.  The "offset" field, which is used to locate profiles
> within the profile is restricted to a u16.
>
> This restricts the number of profiles that can be loaded. This patch
> addresses this limitation by increasing the size of the "offset" field.
>
> Fixes: 11c730bfbf5b ("octeontx2-af: support for coalescing KPU profiles")
> Signed-off-by: Hariprasad Kelam <hkelam@...vell.com>
LGTM
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@...adcom.com>
> ---
>  drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> index e350242bbafb..be709f83f331 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> @@ -1657,7 +1657,7 @@ static int npc_fwdb_detect_load_prfl_img(struct rvu *rvu, uint64_t prfl_sz,
>         struct npc_coalesced_kpu_prfl *img_data = NULL;
>         int i = 0, rc = -EINVAL;
>         void __iomem *kpu_prfl_addr;
> -       u16 offset;
> +       u32 offset;
>
>         img_data = (struct npc_coalesced_kpu_prfl __force *)rvu->kpu_prfl_addr;
>         if (le64_to_cpu(img_data->signature) == KPU_SIGN &&
> --
> 2.17.1
>
>


-- 
Regards,
Kalesh A P

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4239 bytes)