linux-kernel - Re: [PATCH RESEND] kernel: replace seq_puts by seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240326121303.7633eca8@gandalf.local.home>
Date: Tue, 26 Mar 2024 12:13:03 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Maxim Moskalets <maximmosk4@...il.com>
Cc: bristot@...hat.com, bsegall@...gle.com, dietmar.eggemann@....com,
 juri.lelli@...hat.com, linux-kernel@...r.kernel.org, mgorman@...e.de,
 mingo@...hat.com, peterz@...radead.org, vincent.guittot@...aro.org,
 vschneid@...hat.com, Maxim.Moskalets@...persky.com
Subject: Re: [PATCH RESEND] kernel: replace seq_puts by seq_putc

On Mon, 25 Mar 2024 22:28:29 +0300
Maxim Moskalets <maximmosk4@...il.com> wrote:

> Using seq_putc for single characters is faster and more appropriate
> than seq_puts, since only one character is passed and there is no need
> to use a more powerful and less fast function.
> 
> Signed-off-by: Maxim Moskalets <Maxim.Moskalets@...persky.com>
> ---
>  kernel/bpf/arraymap.c            |  6 +++---
>  kernel/bpf/bpf_struct_ops.c      |  2 +-
>  kernel/bpf/hashtab.c             |  4 ++--
>  kernel/bpf/local_storage.c       |  4 ++--
>  kernel/cgroup/cgroup.c           |  2 +-
>  kernel/cgroup/debug.c            |  6 +++---
>  kernel/latencytop.c              |  2 +-
>  kernel/locking/lockdep_proc.c    | 24 ++++++++++++------------
>  kernel/module/procfs.c           |  4 ++--
>  kernel/module/tracking.c         |  2 +-
>  kernel/sched/cpuacct.c           |  4 ++--
>  kernel/sched/debug.c             | 14 +++++++-------
>  kernel/time/test_udelay.c        |  2 +-
>  kernel/trace/trace_events_hist.c | 26 +++++++++++++-------------
>  kernel/trace/trace_events_user.c |  8 ++++----
>  kernel/trace/trace_hwlat.c       |  4 ++--
>  16 files changed, 57 insertions(+), 57 deletions(-)
> 

It's probably better to break this up per sub-system and send them out as
separate patches. At least that way the maintainers of the subsystems can
take the patch. Otherwise, nobody is going to take ownership of this.

-- Steve


> diff --git a/kernel/bpf/arraymap.c b/kernel/bpf/arraymap.c