linux-kernel - Re: [PATCH 11/12] [v4] kallsyms: rework symbol lookup return codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 26 Mar 2024 18:10:32 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Steven Rostedt" <rostedt@...dmis.org>, "Arnd Bergmann" <arnd@...nel.org>
Cc: linux-kbuild@...r.kernel.org, "Masahiro Yamada" <masahiroy@...nel.org>,
 "Alexei Starovoitov" <ast@...nel.org>,
 "Daniel Borkmann" <daniel@...earbox.net>,
 "Andrii Nakryiko" <andrii@...nel.org>,
 "Masami Hiramatsu" <mhiramat@...nel.org>,
 "Luis Chamberlain" <mcgrof@...nel.org>, "Nicolas Schier" <nicolas@...sle.eu>,
 "Nathan Chancellor" <nathan@...nel.org>,
 "Eduard Zingerman" <eddyz87@...il.com>, "Song Liu" <song@...nel.org>,
 "Yonghong Song" <yonghong.song@...ux.dev>,
 "Kees Cook" <keescook@...omium.org>, bpf@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 linux-modules@...r.kernel.org
Subject: Re: [PATCH 11/12] [v4] kallsyms: rework symbol lookup return codes

On Tue, Mar 26, 2024, at 18:06, Steven Rostedt wrote:
> On Tue, 26 Mar 2024 15:53:38 +0100
> Arnd Bergmann <arnd@...nel.org> wrote:
>
>> -const char *
>> +int
>>  ftrace_mod_address_lookup(unsigned long addr, unsigned long *size,
>>  		   unsigned long *off, char **modname, char *sym)
>>  {
>>  	struct ftrace_mod_map *mod_map;
>> -	const char *ret = NULL;
>> +	int ret;
>
> This needs to be ret = 0;

Fixed now, thanks!

I'll send a v5 in a few days 

    Arnd