linux-kernel - Re: [PATCH] iommu/arm-smmu-v3: Fix access for STE.SHCFG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 26 Mar 2024 17:23:18 +0000
From: Will Deacon <will@...nel.org>
To: robin.murphy@....com,
	linux-arm-kernel@...ts.infradead.org,
	iommu@...ts.linux.dev,
	Mostafa Saleh <smostafa@...gle.com>
Cc: catalin.marinas@....com,
	kernel-team@...roid.com,
	Will Deacon <will@...nel.org>,
	linux-kernel@...r.kernel.org,
	joro@...tes.org,
	nicolinc@...dia.com,
	mshavit@...gle.com,
	Jason Gunthorpe <jgg@...pe.ca>
Subject: Re: [PATCH] iommu/arm-smmu-v3: Fix access for STE.SHCFG

On Sat, 23 Mar 2024 13:46:58 +0000, Mostafa Saleh wrote:
> STE attributes(NSCFG, PRIVCFG, INSTCFG) use value 0 for "Use Icomming",
> for some reason SHCFG doesn't follow that, and it is defined as "0b01".
> 
> Currently the driver sets SHCFG to Use Incoming for stage-2 and bypass
> domains.
> 
> However according to the User Manual (ARM IHI 0070 F.b):
> 	When SMMU_IDR1.ATTR_TYPES_OVR == 0, this field is RES0 and the
> 	incoming Shareability attribute is used.
> 
> [...]

Applied to will (for-joerg/arm-smmu/fixes), thanks!

[1/1] iommu/arm-smmu-v3: Fix access for STE.SHCFG
      https://git.kernel.org/will/c/ec9098d6bffe

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev