[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <0033d14d-f1ad-4e18-8b9d-42aa255391c5@amd.com>
Date: Tue, 26 Mar 2024 23:04:54 +0530
From: "Khatri, Sunil" <sukhatri@....com>
To: Alex Deucher <alexdeucher@...il.com>, Sunil Khatri <sunil.khatri@....com>
Cc: Alex Deucher <alexander.deucher@....com>,
Christian König <christian.koenig@....com>,
Shashank Sharma <shashank.sharma@....com>, amd-gfx@...ts.freedesktop.org,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
Hawking Zhang <Hawking.Zhang@....com>,
Felix Kuehling <Felix.Kuehling@....com>, Lijo Lazar <lijo.lazar@....com>
Subject: Re: [PATCH] drm/amdgpu: add support of bios dump in devcoredump
On 3/26/2024 10:23 PM, Alex Deucher wrote:
> On Tue, Mar 26, 2024 at 10:38 AM Sunil Khatri <sunil.khatri@....com> wrote:
>> dump the bios binary in the devcoredump.
>>
>> Signed-off-by: Sunil Khatri <sunil.khatri@....com>
>> ---
>> .../gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 20 +++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c
>> index 44c5da8aa9ce..f33963d777eb 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c
>> @@ -132,6 +132,26 @@ amdgpu_devcoredump_read(char *buffer, loff_t offset, size_t count,
>> drm_printf(&p, "Faulty page starting at address: 0x%016llx\n", fault_info->addr);
>> drm_printf(&p, "Protection fault status register: 0x%x\n\n", fault_info->status);
>>
>> + /* Dump BIOS */
>> + if (coredump->adev->bios && coredump->adev->bios_size) {
>> + int i = 0;
>> +
>> + drm_printf(&p, "BIOS Binary dump\n");
>> + drm_printf(&p, "Valid BIOS Size:%d bytes type:%s\n",
>> + coredump->adev->bios_size,
>> + coredump->adev->is_atom_fw ?
>> + "Atom bios":"Non Atom Bios");
>> +
>> + while (i < coredump->adev->bios_size) {
>> + /* Printing 15 bytes in a line */
>> + if (i % 15 == 0)
>> + drm_printf(&p, "\n");
>> + drm_printf(&p, "0x%x \t", coredump->adev->bios[i]);
>> + i++;
>> + }
>> + drm_printf(&p, "\n");
>> + }
> I don't think it's too useful to dump this as text. I was hoping it
> could be a binary. I guess, we can just get this from debugfs if we
> need it if a binary is not possible.
Yes , this dumps in text format only and the binary is already available
in debugfs. So discarding the patch.
>
> Alex
>
>
>> +
>> /* Add ring buffer information */
>> drm_printf(&p, "Ring buffer information\n");
>> for (int i = 0; i < coredump->adev->num_rings; i++) {
>> --
>> 2.34.1
>>
Powered by blists - more mailing lists