linux-kernel - Re: [PATCH] RAS/AMD/FMPM: Fix build when debugfs is not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tcsBk3Aptyd1jl1fHPAjd-OSYS1s-scsu-L24w59jkOzzblk20pNrYU5d_1j_rllZWVp5pxgzxfx4dkxT4zvnAfWw-bCIcDx0Q9TRU_Aja8=@protonmail.com>
Date: Tue, 26 Mar 2024 18:37:25 +0000
From: A <akira.2020@...tonmail.com>
To: Yazen Ghannam <yazen.ghannam@....com>, "bp@...en8.de" <bp@...en8.de>, "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] RAS/AMD/FMPM: Fix build when debugfs is not enabled

On Tuesday, March 26th, 2024 at 14:29, Yazen Ghannam <yazen.ghannam@....com> wrote:

> 
> 
> On 3/26/24 10:20, A wrote:
> [...]
> 
> > > diff --git a/drivers/ras/debugfs.h b/drivers/ras/debugfs.h
> > > index 4749ccdeeba1..ab95831e7710 100644
> > > --- a/drivers/ras/debugfs.h
> > > +++ b/drivers/ras/debugfs.h
> > > @@ -4,6 +4,10 @@
> > > 
> > > #include <linux/debugfs.h>
> > > 
> > > +#if IS_ENABLED(DEBUG_FS)
> > > struct dentry *ras_get_debugfs_root(void);
> > > +#else
> > > +static inline struct dentry ras_get_debugfs_root(void) { return NULL; }
> > > +#endif / DEBUG_FS /
> > > 
> > > #endif / RAS_DEBUGFS_H */
> > 
> > this also works, just tested
> > 
> > this time round, `make oldconfig` asks if i want to build RAS_FMPM, i built it as module, compilation succeeds.
> 
> 
> Thanks for testing!
> 
> Would you mind including your "Tested-by" tag? I can include this when I
> send a proper patch.
> 
> Thanks,
> Yazen

sure, tested-by:  anthony s. knowles <akira.2020@...tonmail.com>

kind regards,
a.s.k