linux-kernel - Re: [PATCH 6.6 430/638] powerpc/ps3: Fix lv1 hcall assembly for ELFv2 calling convention

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 26 Mar 2024 15:20:05 -0400
From: Sasha Levin <sashal@...nel.org>
To: Michael Ellerman <mpe@...erman.id.au>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Nicholas Piggin <npiggin@...il.com>,
	Geoff Levand <geoff@...radead.org>
Subject: Re: [PATCH 6.6 430/638] powerpc/ps3: Fix lv1 hcall assembly for
 ELFv2 calling convention

On Tue, Mar 26, 2024 at 03:36:15PM +1100, Michael Ellerman wrote:
>Sasha Levin <sashal@...nel.org> writes:
>> From: Nicholas Piggin <npiggin@...il.com>
>>
>> [ Upstream commit 6735fef14c1f089ae43fd6d43add818b7ff682a8 ]
>>
>> Stack-passed parameters begin at a different offset in the caller's
>> stack in the ELFv2 ABI.
>>
>> Reported-by: Geoff Levand <geoff@...radead.org>
>> Fixes: 8c5fa3b5c4df ("powerpc/64: Make ELFv2 the default for big-endian builds")
>> Signed-off-by: Nicholas Piggin <npiggin@...il.com>
>> Tested-by: Geoff Levand <geoff@...radead.org>
>> Signed-off-by: Michael Ellerman <mpe@...erman.id.au>
>> Link: https://msgid.link/20231227072405.63751-2-npiggin@gmail.com
>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>> ---
>>  arch/powerpc/include/asm/ppc_asm.h  |  6 ++++--
>>  arch/powerpc/platforms/ps3/hvcall.S | 18 +++++++++---------
>>  2 files changed, 13 insertions(+), 11 deletions(-)
>
>This commit is OK on its own, but it doesn't have any effect unless the
>full series up to 914d081ead11 ("Revert "powerpc/ps3_defconfig: Disable
>PPC64_BIG_ENDIAN_ELF_ABI_V2"") is backported.
>
>I don't think the full series warrants backporting, it's really enabling
>a new feature (ELFv2 build for ps3).
>
>So IMHO please drop this patch from 6.6, 6.7, 6.8.

Dropped, thanks!

-- 
Thanks,
Sasha