linux-kernel - Re: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 26 Mar 2024 12:32:40 -0700
From: Abhinav Kumar <quic_abhinavk@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
        Rob Clark
	<robdclark@...il.com>, Sean Paul <sean@...rly.run>,
        Marijn Suijten
	<marijn.suijten@...ainline.org>,
        David Airlie <airlied@...il.com>, Daniel
 Vetter <daniel@...ll.ch>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        <freedreno@...ts.freedesktop.org>,
        linux-kernel
	<linux-kernel@...r.kernel.org>
Subject: Re: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error:
 variable 'out' set but not used



On 3/26/2024 12:10 PM, Dmitry Baryshkov wrote:
> On Tue, 26 Mar 2024 at 20:31, Abhinav Kumar <quic_abhinavk@...cinc.com> wrote:
>>
>>
>>
>> On 3/26/2024 11:19 AM, Dmitry Baryshkov wrote:
>>> On Tue, 26 Mar 2024 at 20:05, Miguel Ojeda
>>> <miguel.ojeda.sandonis@...il.com> wrote:
>>>>
>>>> Hi,
>>>>
>>>> In today's next, I got:
>>>>
>>>>       drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable
>>>> 'out' set but not used [-Werror,-Wunused-but-set-variable]
>>>>
>>>> `out` seems to be there since commit 64d6255650d4 ("drm/msm: More
>>>> fully implement devcoredump for a7xx").
>>>>
>>>> Untested diff below assuming `dumper->iova` is constant -- if you want
>>>> a formal patch, please let me know.
>>>
>>> Please send a proper patch that we can pick up.
>>>
>>
>> This should be fixed with https://patchwork.freedesktop.org/patch/581853/.
> 
> Is that a correct fix? If you check other usage locations for
> CRASHDUMP_READ, you'll see that `out` is the last parameter and it is
> being incremented.
> 

Right but in this function out is not the last parameter of CRASHDUMP_READ.

Maybe you or Rob can correct me but I thought the fix looked sane 
although noone commented on that patch.

>>
>> We can pickup that one with a Fixes tag applied.
>>
>>>>
>>>> Cheers,
>>>> Miguel
>>>>
>>>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
>>>> b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
>>>> index 1f5245fc2cdc..a847a0f7a73c 100644
>>>> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
>>>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
>>>> @@ -852,7 +852,7 @@ static void a6xx_get_shader_block(struct msm_gpu *gpu,
>>>>                (block->type << 8) | i);
>>>>
>>>>            in += CRASHDUMP_READ(in, REG_A6XX_HLSQ_DBG_AHB_READ_APERTURE,
>>>> -            block->size, dumper->iova + A6XX_CD_DATA_OFFSET);
>>>> +            block->size, out);
>>>>
>>>>            out += block->size * sizeof(u32);
>>>>        }
>>>
>>>
>>>
> 
> 
>